Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1741136: Use 1 decimal place for values < 100, 0 otherwise #2361

Closed
wants to merge 1 commit into from

Conversation

rawagner
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 15, 2019
@openshift-ci-robot
Copy link
Contributor

@rawagner: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1741136: Use 1 decimal place for values < 100, 0 otherwise

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 15, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rawagner
To complete the pull request process, please assign rhamilto
You can assign the PR to them by writing /assign @rhamilto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like a better approach is to use Intl.NumberFormat to format based on the user's locale and specify the number of significant digits.

}
return 1;
};
const getDefaultFractionDigits = value => value < 100 ? 1 : 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it will break display of small values like 0.003 cores

@spadgett
Copy link
Member

/assign

@spadgett
Copy link
Member

We should get the unit tests running in CI (#2204) and make sure they pass before making further changes.

@openshift-ci-robot
Copy link
Contributor

@rawagner: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 32a5a3f link /test e2e-gcp-console
ci/prow/e2e-gcp 32a5a3f link /test e2e-gcp
ci/prow/analyze 32a5a3f link /test analyze

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett spadgett closed this Jun 18, 2020
@openshift-ci-robot
Copy link
Contributor

@rawagner: This pull request references Bugzilla bug 1741136. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1741136: Use 1 decimal place for values < 100, 0 otherwise

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants