downstream builds sass from source; rh-manifest.txt #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
downstream we cannot get sass and node-sass from the internet and haven't packaged them so instead they install/build from source.
openshift-ci-robot
added
the
size/XXL
|
👍 Thanks. We should probably remove bill-of-materials.json to avoid having two files like this. bill-of-materials.json is also out of date. |
|
We should try to automate this. I'm worried it will drift from yarn.lock. yarn.lock is really the source of truth. |
|
Yes, on all counts. Just trying to get anything working right now :)
…On Wed, Sep 12, 2018 at 12:30 PM Sam Padgett ***@***.***> wrote:
We should try to automate this. I'm worried it will drift from yarn.lock.
yarn.lock is really the source of truth.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#523 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABz-mrRde1C8Ipp91rFsnk5WnaW7t8vks5uaTavgaJpZM4Wlvly>
.
|
sosiouxme
force-pushed
the
20180912-sass-from-source
branch
from
d600350 to
d3d205c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@spadgett this purifies the downstream build sources so they will finally be acceptable. Also I added rh-manifest.txt so PST can see what's in it.
This addresses 3.11. Shortly I'll have to do a similar update for next version, and hopefully nail down the process somewhat.