Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Backups of Etcd #1486

Merged

Conversation

hasbro17
Copy link
Contributor

@hasbro17 hasbro17 commented Oct 3, 2023

This PR resurrects the proposal for automated backups of etcd from #1370

Given that the actual API and implementation PRs have already been merged for this feature, this proposal is more descriptive than prescriptive. While the original proposal had more what-ifs and open ended questions more relevant to the initial design phase, this proposal documents the changes we made as the API and implementation details have evolved since then.

The only piece that's left for a follow up is the no-opinion Backup config that would save and spread backups across all nodes with a default retention policy.

/cc @tjungblu @dusk125

@openshift-ci openshift-ci bot requested review from dusk125 and tjungblu October 3, 2023 04:40
@openshift-merge-robot
Copy link
Contributor

@hasbro17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/markdownlint ed885e1 link true /test markdownlint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

- "@tjungblu"
- "@williamcaban"
approvers:
- "@tjungblu"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and approved :)
Thanks @hasbro17.

@hasbro17
Copy link
Contributor Author

Forgot this was still hanging around.

Linting: 569 file(s)
Summary: 1 error(s)
enhancements/etcd/automated-backups.md:158:401 MD013/line-length Line length [Expected: 400; Actual: 864]

That's due to the rather long regex on the cron format which is unavoidable. Going to try and override the linter job since there seem to be no other issues.

/override ci/prow/markdownlint

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

@hasbro17: Overrode contexts on behalf of hasbro17: ci/prow/markdownlint

In response to this:

Forgot this was still hanging around.

Linting: 569 file(s)
Summary: 1 error(s)
enhancements/etcd/automated-backups.md:158:401 MD013/line-length Line length [Expected: 400; Actual: 864]

That's due to the rather long regex on the cron format which is unavoidable. Going to try and override the linter job since there seem to be no other issues.

/override ci/prow/markdownlint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

@hasbro17: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hasbro17
Copy link
Contributor Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@tjungblu
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@openshift-ci openshift-ci bot merged commit 7393145 into openshift:master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants