-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated Backups of Etcd #1486
Automated Backups of Etcd #1486
Conversation
@hasbro17: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
- "@tjungblu" | ||
- "@williamcaban" | ||
approvers: | ||
- "@tjungblu" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and approved :)
Thanks @hasbro17.
Forgot this was still hanging around.
That's due to the rather long regex on the cron format which is unavoidable. Going to try and override the linter job since there seem to be no other issues. /override ci/prow/markdownlint |
@hasbro17: Overrode contexts on behalf of hasbro17: ci/prow/markdownlint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hasbro17: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasbro17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This PR resurrects the proposal for automated backups of etcd from #1370
Given that the actual API and implementation PRs have already been merged for this feature, this proposal is more descriptive than prescriptive. While the original proposal had more what-ifs and open ended questions more relevant to the initial design phase, this proposal documents the changes we made as the API and implementation details have evolved since then.
The only piece that's left for a follow up is the no-opinion Backup config that would save and spread backups across all nodes with a default retention policy.
/cc @tjungblu @dusk125