Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOWNSTREAM: <carry>: ETCD-697: add tls min/max version to grpc proxy #301

Merged

Conversation

tjungblu
Copy link

@tjungblu tjungblu commented Nov 4, 2024

This adds the min and max TLS version support from etcd-io#13506 and etcd-io#15156 to the grpc proxy.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This adds the min and max TLS version support from etcd-io#13506 and etcd-io#15156 to the grpc proxy.

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@dusk125
Copy link

dusk125 commented Nov 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tjungblu
Copy link
Author

tjungblu commented Nov 5, 2024

/override ci/prow/configmap-scale

Copy link

openshift-ci bot commented Nov 5, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/configmap-scale

In response to this:

/override ci/prow/configmap-scale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tjungblu tjungblu changed the title DOWNSTREAM: <carry>: add tls min/max version to grpc proxy DOWNSTREAM: <carry>: ETCD-697: add tls min/max version to grpc proxy Nov 5, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2024

@tjungblu: This pull request references ETCD-697 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This adds the min and max TLS version support from etcd-io#13506 and etcd-io#15156 to the grpc proxy.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tjungblu
Copy link
Author

tjungblu commented Nov 5, 2024

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2024

@tjungblu: This pull request references ETCD-697 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tjungblu
Copy link
Author

tjungblu commented Nov 5, 2024

/override ci/prow/configmap-scale

Copy link

openshift-ci bot commented Nov 5, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/configmap-scale

In response to this:

/override ci/prow/configmap-scale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ad72abe and 2 for PR HEAD 070d2ce in total

@tjungblu
Copy link
Author

tjungblu commented Nov 5, 2024

/override ci/prow/configmap-scale

Copy link

openshift-ci bot commented Nov 5, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/configmap-scale

In response to this:

/override ci/prow/configmap-scale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tjungblu
Copy link
Author

tjungblu commented Nov 5, 2024

/override ci/prow/e2e-aws-ovn-serial

unrelated feature gates failing

Copy link

openshift-ci bot commented Nov 5, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-serial

In response to this:

/override ci/prow/e2e-aws-ovn-serial

unrelated feature gates failing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Nov 5, 2024

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery 070d2ce link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-serial 070d2ce link unknown /test e2e-aws-ovn-serial
ci/prow/configmap-scale 070d2ce link true /test configmap-scale

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e8a81ba into openshift:openshift-4.18 Nov 5, 2024
9 of 10 checks passed
@tjungblu tjungblu deleted the luisbackporttls branch November 5, 2024 15:32
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-etcd
This PR has been included in build ose-etcd-container-v4.18.0-202411051638.p0.ge8a81ba.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-etcd-artifacts
This PR has been included in build ose-installer-etcd-artifacts-container-v4.18.0-202411051638.p0.ge8a81ba.assembly.stream.el9.
All builds following this will include this PR.

Elbehery pushed a commit to Elbehery/etcd that referenced this pull request Nov 14, 2024
DOWNSTREAM: <carry>: ETCD-697: add tls min/max version to grpc proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants