Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1859196: bump etcd v3.4.9 #52

Merged
merged 46 commits into from
Jul 22, 2020
Merged

Bug 1859196: bump etcd v3.4.9 #52

merged 46 commits into from
Jul 22, 2020

Conversation

hexfusion
Copy link

@hexfusion hexfusion commented Jul 15, 2020 •
edited
Loading

This PR bumps etcd to v3.4.9 from v3.4.7 which includes a few important bugfixes:

etcd server

3.4.8 changelog: https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.4.md#v348-2020-05-18
3.4.9 changelog: https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.4.md#v349-2020-05-20

CARRY:

polyrabbit and others added 30 commits April 6, 2020 07:06
@polyrabbit @jingyih
etcdserver: watch stream got closed once one request is not permitted (…
9c85545 
…etcd-io#11708)
@spzala
Merge pull request etcd-io#11757 from jingyih/automated-cherry-pick-o…
e2ae601 
…f-#11754-upstream-release-3.4

Automated cherry pick of etcd-io#11754 on release-3.4
@tangcong
*: fix auth revision corruption bug
347c8da
@wswcfan @tangcong
tools/etcd-dump-db: add auth decoder, optimize print format
b3d54de
@wswcfan @tangcong
auth: add new metric 'etcd_debugging_auth_revision'
63116ff
@tangcong
auth: print warning log when error is ErrAuthOldRevision
716821b
@tangcong
auth: cleanup saveConsistentIndex in NewAuthStore
e2abd97
@tangcong
etcdserver: print warn log when failed to apply request
eb80716
@tangcong
auth: ensure RoleGrantPermission is compatible with older versions
b733b22
@jingyih
Merge pull request etcd-io#11752 from tangcong/automated-cherry-pick-…
f1eca4e 
…of-#11652-etcd-io#11670-etcd-io#11710-origin-release-3.4

Automated cherry pick of etcd-io#11652 etcd-io#11670 etcd-io#11710
@wswcfan
auth: optimize lock scope for CheckPassword
f18976f 
to improve authentication performance in concurrent scenarios when enable auth and using authentication based password
@tangcong
mvcc: fix deadlock bug
aa75e90
@gyuho
Merge pull request etcd-io#11855 from tangcong/automated-cherry-pick-…
2333c72 
…of-#11817-origin-release-3.4

Automated cherry pick of etcd-io#11817 on release-3.4
@gdbelvin @eddycjy
@gyuho @YoyinZyc
cherry pick of etcd-io#11564 (etcd-io#11880)
e048e16 
* clientv3: fix grpc-go(v1.27.0) incompatible changes to balancer/resolver.

* vendor: upgrade gRPC Go to v1.24.0

Picking up some performance improvements and bug fixes.

https://github.com/grpc/grpc-go/releases/tag/v1.24.0

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>

* vendor: update gRPC Go to v1.26.0 (etcd-io#11522)

* GO111MODULE=on go mod vendor

* GO111MODULE=on go mod vendor go 1.14

Bump travis 2

Co-authored-by: EDDYCJY <313687982@qq.com>
Co-authored-by: Gyuho Lee <leegyuho@amazon.com>
Co-authored-by: Yuchen Zhou <yczhou@google.com>
@gyuho
etcdserver,wal: fix inconsistencies in WAL and snapshot
87fc3c9 
etcdserver/*, wal/*: changes to snapshots and wal logic
etcdserver/*: changes to snapshots and wal logic to fix etcd-io#10219
etcdserver/*, wal/*: add Sync method
etcdserver/*, wal/*: find valid snapshots by cross checking snap files and wal snap entries
etcdserver/*, wal/*:Add comments, clean up error messages and tests
etcdserver/*, wal/*: Remove orphaned .snap.db files during Release

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@tedyu @gyuho
etcdserver: continue releasing snap db in case of error
4079dea 
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
etcdserver/api/snap: exclude orphaned defragmentation files in snapNames
f1ea03a 
ref. etcd-io#11900

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
*: make sure snapshot save downloads SHA256 checksum
9bad82f 
ref. etcd-io#11896

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
rafthttp: improve snapshot send logging
a668adb 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
version: 3.4.8
0de2b1f 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
rafthttp: log snapshot download duration
cfe37de 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@tangcong @gyuho
wal: fix crc mismatch crash bug
ed231df
@tangcong @gyuho
wal: add TestValidSnapshotEntriesAfterPurgeWal testcase
166b447 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
Merge pull request etcd-io#11811 from wswcfan/automated-cherry-pick-o…
609e844 
…f-#11735-origin-release-3.4

Automated cherry pick of etcd-io#11735 on release-3.4
@gyuho
version: 3.4.9
54ba958 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@hexfusion
version: openshift-v4.0
f6a7557 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Dockerfile: add etcdctl
c356849 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@wking @hexfusion
Dockerfile.*: Fix "etcd is distributed" -> "etcd is a distributed"
b079aae 
Correcting a typo from 2f10964 (version: openshift-v4.0, 2018-11-29).
@hexfusion
Dockerfile: resolve issue where binary was not properly copied from b…
934df72 
…uild.

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
OWNERS: add
2e940c6 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Copy link
Author

soak
/test all

@hexfusion
Copy link
Author

/test e2e-aws-upgrade

@hexfusion hexfusion changed the title bump etcd v3.4.9 Bug 1859196: bump etcd v3.4.9 Jul 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 21, 2020
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1859196, which is invalid:

  • expected Bugzilla bug 1859196 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1859196: bump etcd v3.4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

3 similar comments
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1859196, which is invalid:

  • expected Bugzilla bug 1859196 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1859196: bump etcd v3.4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1859196, which is invalid:

  • expected Bugzilla bug 1859196 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1859196: bump etcd v3.4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1859196, which is invalid:

  • expected Bugzilla bug 1859196 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1859196: bump etcd v3.4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion
Copy link
Author

cc @sdodson

@sdodson
Copy link
Member

sdodson commented Jul 21, 2020

@hexfusion Not familiar with this repo, you're already branched for 4.6 or should this go into master and openshift-4.6 gets fast forwarded?

@hexfusion
Copy link
Author

@sdodson master is upstream as we are a fork.

@retroflexer
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, retroflexer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1859196, which is invalid:

  • expected Bugzilla bug 1859196 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jul 21, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@sdodson: This pull request references Bugzilla bug 1859196, which is invalid:

  • expected Bugzilla bug 1859196 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 21, 2020
@sdodson
Copy link
Member

sdodson commented Jul 21, 2020

Bot config needs to be looked into, 4.6.0 bugs shouldn't require dependents.

@hexfusion
Copy link
Author

shouldn't need cherry-pick approved either I suspect

@hexfusion hexfusion added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 21, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jul 21, 2020

/retest

@hexfusion hexfusion mentioned this pull request Jul 22, 2020
Merged
@openshift-merge-robot openshift-merge-robot merged commit 8a0b82e into openshift:openshift-4.6 Jul 22, 2020
@openshift-ci-robot
Copy link

@hexfusion: All pull requests linked via external trackers have merged: . Bugzilla bug 1859196 has been moved to the MODIFIED state.

In response to this:

Bug 1859196: bump etcd v3.4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford Awaiting requested review from crawford

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@retroflexer retroflexer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.