-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: <carry>: storage/backend: Add a gauge to indicate if defrag is active #97
UPSTREAM: <carry>: storage/backend: Add a gauge to indicate if defrag is active #97
Conversation
@hexfusion: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
manually adding valid bug as it is not required in 4.10 during dev cycle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I'm guessing this should make it easier to check whether defrag controller is active during latency spikes (and thus make our hand wringing more efficient).
Right is the members store still being actively defragmented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasbro17, hexfusion, lilic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cherry-pick of etcd-io#13371
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.