-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kind annotation to EC ITS #828
Conversation
Can one of the admins verify this patch? |
Hi @zregvart. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Typo in PR title FYI: s/ annotatition / annotation / |
@simonbaird: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
400f217
to
ccfb565
Compare
The auto-created Enterprise Contract IntegrationTestScenarios are now annotated with `test.appstudio.openshift.io/kind: enterprise-contract` annotation. Ref. https://issues.redhat.com/browse/HACBS-2547
ccfb565
to
214367f
Compare
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
==========================================
+ Coverage 85.22% 85.24% +0.01%
==========================================
Files 587 587
Lines 14492 14499 +7
Branches 4050 4054 +4
==========================================
+ Hits 12351 12359 +8
+ Misses 2009 2008 -1
Partials 132 132
Continue to review full report in Codecov by Sentry.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karthikjeeyar, simonbaird, zregvart The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@zregvart: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixes
Description
The auto-created Enterprise Contract IntegrationTestScenarios are now annotated with
test.appstudio.openshift.io/kind: enterprise-contract
annotation.Type of change
Screen shots / Gifs for design review
n/a
How to test or reproduce?
Create an Application, and check that the auto-generated Enterprise Contract IntegrationTestScenario has the
test.appstudio.openshift.io/kind: enterprise-contract
annotation.Browser conformance:
This change should be browser independent, it only contains logic changes and doesn't touch the browser.
Checklist: