Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kind annotation to EC ITS #828

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

zregvart
Copy link
Contributor

@zregvart zregvart commented Oct 3, 2023

Fixes

Description

The auto-created Enterprise Contract IntegrationTestScenarios are now annotated with test.appstudio.openshift.io/kind: enterprise-contract annotation.

Type of change

  • Feature

Screen shots / Gifs for design review

n/a

How to test or reproduce?

Create an Application, and check that the auto-generated Enterprise Contract IntegrationTestScenario has the test.appstudio.openshift.io/kind: enterprise-contract annotation.

Browser conformance:

This change should be browser independent, it only contains logic changes and doesn't touch the browser.

  • Chrome
  • Firefox
  • Safari
  • Edge

Checklist:

  • Code follows the style guidelines
  • Self-reviewed the code
  • Added comments in hard-to-understand areas
  • Made corresponding changes to the documentation
  • Changes generate no new warnings
  • Added tests that prove this fix is effective or that the feature works
  • New and existing unit tests pass locally with new changes
  • Any dependent changes have been merged and published in downstream modules

@app-sre-bot
Copy link

Can one of the admins verify this patch?

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

Hi @zregvart. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonbaird
Copy link
Contributor

Typo in PR title FYI: s/ annotatition / annotation /

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

@simonbaird: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zregvart zregvart changed the title feat: add kind annotatition to EC ITS feat: add kind annotation to EC ITS Oct 4, 2023
The auto-created Enterprise Contract IntegrationTestScenarios are now
annotated with `test.appstudio.openshift.io/kind: enterprise-contract`
annotation.

Ref. https://issues.redhat.com/browse/HACBS-2547
@rohitkrai03
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #828 (214367f) into main (256ea5d) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
+ Coverage   85.22%   85.24%   +0.01%     
==========================================
  Files         587      587              
  Lines       14492    14499       +7     
  Branches     4050     4054       +4     
==========================================
+ Hits        12351    12359       +8     
+ Misses       2009     2008       -1     
  Partials      132      132              
Files Coverage Δ
...nents/IntegrationTest/IntegrationTestForm/const.ts 100.00% <100.00%> (ø)
...nents/IntegrationTest/IntegrationTestForm/types.ts 100.00% <100.00%> (ø)
...tionTest/IntegrationTestForm/utils/create-utils.ts 79.16% <100.00%> (+3.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 256ea5d...214367f. Read the comment docs.

@karthikjeeyar
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karthikjeeyar, simonbaird, zregvart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@karthikjeeyar
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@zregvart: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit c111901 into openshift:main Oct 10, 2023
2 checks passed
@zregvart zregvart deleted the issue/HACBS-2547 branch October 10, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants