Skip to content

Commit

Permalink
Merge pull request #620 from ironcladlou/optimize-api-doc-gen
Browse files Browse the repository at this point in the history
Reduce API docs generation time by 97%
  • Loading branch information
openshift-merge-robot authored Oct 29, 2021
2 parents d72ba28 + a1d4f1d commit 539a0aa
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ cluster-api-provider-ibmcloud: $(CONTROLLER_GEN)

.PHONY: api-docs
api-docs: $(GENAPIDOCS)
$(GENAPIDOCS) --config $(DIR)/docs/api-doc-gen/config.json --template-dir $(DIR)/docs/api-doc-gen/templates --api-dir ./api/v1alpha1 --out-file $(DIR)/docs/content/reference/api.md
hack/gen-api-docs.sh $(GENAPIDOCS) $(DIR)

# Run tests
.PHONY: test
Expand Down
28 changes: 28 additions & 0 deletions hack/gen-api-docs.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
#!/bin/bash

# This generation script sets up a fake GOPATH for docs generation
# to work around performance issues in the upstream code generation
# libraries. See:
#
# https://github.com/kubernetes/gengo/issues/147
# https://github.com/kubernetes/code-generator/issues/69

GEN_BIN="$1"
REPO_ROOT_DIR="$2"

FAKE_GOPATH="$(mktemp -d)"
trap 'rm -rf ${FAKE_GOPATH}' EXIT

FAKE_REPOPATH="${FAKE_GOPATH}/src/github.com/openshift/hypershift"
mkdir -p "$(dirname "${FAKE_REPOPATH}")" && ln -s "${REPO_ROOT_DIR}" "${FAKE_REPOPATH}"

cd "${FAKE_REPOPATH}"

export GOPATH="${FAKE_GOPATH}"
export GO111MODULE="off"

${GEN_BIN} \
--config "${FAKE_REPOPATH}/docs/api-doc-gen/config.json" \
--template-dir "${FAKE_REPOPATH}/docs/api-doc-gen/templates" \
--api-dir ./api/v1alpha1 \
--out-file "${FAKE_REPOPATH}/docs/content/reference/api.md"

0 comments on commit 539a0aa

Please sign in to comment.