Add init container to etcd pods to test DNS #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
enxebre
reviewed
Jan 2, 2023
| echo "Waiting to resolve $HOSTNAME via DNS" | ||
| sleep 5 | ||
| done | ||
| echo "${HOSTNAME} is resolved" |
There was a problem hiding this comment.
is there anything preventing this from just happening immediately?
Waits until a dns lookup of the pod's service hostname can be resolved. This ensures that a statefulset pods do not start until names can be resolved.
|
/lgtm |
|
to get CI working again |
This was referenced Jan 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Waits until a reverse dns lookup of the pod's IP address returns the pod's expected hostname. This ensures that a statefulset does not rollout until names can be resolved.
Checklist