-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install qemu-kvm as part of Libvirt flow #690
Install qemu-kvm as part of Libvirt flow #690
Conversation
Hi @xsgordon. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
docs/dev/libvirt-howto.md
Outdated
@@ -22,7 +22,7 @@ If it is missing, try some of the ideas [here][kvm-install]. | |||
On Fedora, CentOS/RHEL: | |||
|
|||
```sh | |||
sudo yum install libvirt libvirt-devel | |||
sudo yum install libvirt libvirt-devel qemu-kvm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last touch was #514. I'd really rather get something backed by CI, like this, which is entering CI via openshift/release#2143. Based on that (it still hasn't landed), we'd also want libvirt-client, libvirt-daemon-kvm, and bind-utils. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I ran through this on a clean RHEL install the above was enough that I got bind-utils
for "free" (may have been part of the minimal config?) but yes libvirt-daemon-kvm
is needed as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about libvirt-client
? We may not need it for the build, but we have a few virsh
calls in these docs. Or does it get pulled in by another package as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gets pulled in by the above, specifically libvirt-client
is a dependency of libvirt
. qemu-kvm
is not a dependency of libvirt, because Libvirt is hypervisor agnostic and can be used with other hypervisors, even if it is most commonly used with QEMU/KVM.
On RHEL (and IIRC Fedora as well) installing Libvirt doesn't actually automatically mean you pulled in a hypervisor to actually run VMs on. As a result you can encounter this error because qemu-kvm or equivalent is not present: Could not find any guests for architecure type hvm/x86_64 To avoid this, explicitly install qemu-kvm (if qemu-kvm-rhev or qemu-kvm-ev are available in the machine's yum/dnf configuration they will automatically get pulled in instead). The other package needed is libvirt-daemon-kvm.
b0d9f56
to
23b3682
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking, xsgordon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
On RHEL (and IIRC Fedora as well) installing Libvirt doesn't actually
automatically mean you pulled in a hypervisor to actually run VMs on. As
a result you can encounter this error because qemu-kvm or equivalent is
not present:
To avoid this, explicitly install qemu-kvm (if qemu-kvm-rhev or
qemu-kvm-ev are available in the machine's yum/dnf configuration they
will automatically get pulled in instead).