CORS-2902: capi/aws: add ext-LB as CAPA secondary LB #8149
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@r4f4: This pull request references CORS-2902 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/uncc @AnnaZivkovic @andfasano |
openshift-ci
bot
requested review from
mtulio and
patrickdillon
and removed request for
andfasano and
AnnaZivkovic
|
Update: addressed review comments. |
Because it is always created. The ext-LB, when needed, will be added as a secondary LB.
| Name: ptr.To(clusterID.InfraID + "-ext"), | ||
| LoadBalancerType: capa.LoadBalancerTypeNLB, | ||
| Scheme: &capa.ELBSchemeInternetFacing, | ||
| CrossZoneLoadBalancing: true, |
There was a problem hiding this comment.
we need to enable cross zone load balancing on the primary as well, but we could do that in a follow up pr if preferred
There was a problem hiding this comment.
should we enable it only if there is more than 1 subnet setup?
There was a problem hiding this comment.
In terraform we always enable it. I'm going to enable in both and we can review that decision in a follow-up.
|
/approve |
|
/assign @vincepri |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
CAPA does not apply rules specified only in the secondary load balancer. Add the rule to the primary LB instead, since both share the same security group.
For parity with our terraform configs.
|
/test e2e-aws-capi-ovn |
|
@r4f4: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test altinfra-e2e-aws-capi-ovn |
|
/retest-required |
|
@r4f4: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
|
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/altinfra-e2e-aws-capi-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-bot
bot
merged commit 6b4523d
into
openshift:master
This PR makes the internal LB be the primary CAPA load balancer and then adds the external LB as a secondary one when using public endpoints.