CORS-2899: capi-aws - Local Zones network provisioning #8173
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@mtulio: This pull request references CORS-2899 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test ? |
|
@mtulio: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mtulio
force-pushed
the
CORS-2899-edge-zones
branch
from
7cbf306 to
7d6ba98
Compare
|
/test altinfra-e2e-aws-ovn-localzones |
|
@mtulio: This pull request references CORS-2899 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
mtulio
force-pushed
the
CORS-2899-edge-zones
branch
from
7d6ba98 to
f02826b
Compare
|
/test altinfra-e2e-aws-ovn-localzones |
1 similar comment
|
/test altinfra-e2e-aws-ovn-localzones |
mtulio
force-pushed
the
CORS-2899-edge-zones
branch
from
f02826b to
14e913c
Compare
|
Two success cluster creation on Local Zones. Triggering other jobs. |
mtulio
force-pushed
the
CORS-2899-edge-zones
branch
3 times, most recently
from
0fd9ede to
d5dd2c6
Compare
mtulio
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
mtulio
changed the title
|
@mtulio: This pull request references CORS-2899 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test altinfra-e2e-aws-ovn-localzones |
mtulio
force-pushed
the
CORS-2899-edge-zones
branch
from
cfa703b to
0dc1eaf
Compare
|
/test altinfra-e2e-aws-ovn-localzones |
|
@mtulio: This pull request references CORS-2899 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Converting to draft to address the review feedback, and adding more scenarios in the unit tests for cluster CAPA zones. |
mtulio
force-pushed
the
CORS-2899-edge-zones
branch
from
1c9f90d to
854f286
Compare
|
/test unit |
|
@r4f4 thanks for your review. I found one "issue" (mentioned on Slack) which was specifically here (when the worker pool isn't defined, the zone wasn't added). In the practice, it will not generate any issue for the provisioner as the default zones are set earlier, instead a issue caught in the unit validation. I am checking if we'll need to simplify/drop some validations considering the goal is only discover which zones should be used to create subnets, regardless it was added from pools, defaults, or metadata. The ZonesCAPI had been exported and generated a lot of changes in the whole zone code in favor of getting better unit tests feedback using go-cmp. The remaining changes are addressing your feedback. |
The subnet structure created in managed VPC by CAPA is created with SubnetSpec, without providing the valid ID, so CAPA will understand that the subnet does not exists and will created it following the zone specified/discovered in the install config.
mtulio
force-pushed
the
CORS-2899-edge-zones
branch
from
854f286 to
7cebd6a
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test altinfra-e2e-aws-ovn-localzones |
|
/uncc rna-afk sadasu barbacbd |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404251943.p0.g59cc24d.assembly.stream.el8 for distgit ose-installer-altinfra. |
mtulio
changed the title
CORS-2899
This PR introduce support of AWS Local Zones using CAPA as infrastructure provisioner for managed (automated VPC) and unmanaged (BYO VPC) deployments.
References:
Blocked by: