Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-34819: capi/aws: bump provider for fixes #8545

Merged
merged 3 commits into from
Jun 13, 2024
Merged

OCPBUGS-34819: capi/aws: bump provider for fixes #8545

merged 3 commits into from
Jun 13, 2024

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Jun 6, 2024 •
edited
Loading

This version brings in 2 important fixes:

  • Fix duplicated target group names
  • Fix reconciling load balancer in case of errors.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2024
@openshift-ci openshift-ci bot requested review from patrickdillon and sadasu June 6, 2024 22:20
@r4f4
Copy link
Contributor Author

r4f4 commented Jun 6, 2024

/uncc @patrickdillon @sadasu
Will CC again when ready to review.

@openshift-ci openshift-ci bot removed request for sadasu and patrickdillon June 6, 2024 22:21
@r4f4 r4f4 force-pushed the aws-lb-reconcile-fix branch from 61f572f to 9c9ef0f Compare June 12, 2024 05:46
@r4f4
Copy link
Contributor Author

r4f4 commented Jun 12, 2024

/retitle OCPBUGS-34819: capi/aws: bump provider for fixes

@openshift-ci openshift-ci bot changed the title WIP: Aws lb reconcile fix OCPBUGS-34819: capi/aws: bump provider for fixes Jun 12, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 12, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-34819, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Jun 12, 2024

/cherry-pick release-4.16

@openshift-cherrypick-robot
Copy link

@r4f4: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Jun 12, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 12, 2024
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-34819, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gpei June 12, 2024 05:50
@r4f4
Copy link
Contributor Author

r4f4 commented Jun 12, 2024

/assign @patrickdillon
/cc @barbacbd

@openshift-ci openshift-ci bot requested a review from barbacbd June 12, 2024 06:13
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request references Jira Issue OCPBUGS-34819, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

This version brings in 2 important fixes:

  • Fix duplicated target group names
  • Fix reconciling load balancer in case of errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Jun 12, 2024

/hold
We've identified another issue that needs fixing: kubernetes-sigs/cluster-api-provider-aws#5015

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2024
@r4f4 r4f4 force-pushed the aws-lb-reconcile-fix branch from 9c9ef0f to c783324 Compare June 12, 2024 20:08
@r4f4 r4f4 mentioned this pull request Jun 12, 2024
Merged
5 tasks
@r4f4
OCPBUGS-34819: capi/aws: bump provider version
f0afa87 
This version brings in 2 important fixes:
 * Fix duplicated target group names
 * Fix reconciling load balancer in case of errors.
@r4f4 r4f4 force-pushed the aws-lb-reconcile-fix branch from c783324 to 8c53e55 Compare June 13, 2024 11:51
@r4f4
Copy link
Contributor Author

r4f4 commented Jun 13, 2024

Update: capa fix merged upstream. Bumped capa version to include:

  • the target group creation fix
  • BYOIPv4 feature.

@mtulio
Copy link
Contributor

mtulio commented Jun 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@r4f4
Copy link
Contributor Author

r4f4 commented Jun 13, 2024

I can see in the console that https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/8545/pull-ci-openshift-installer-master-altinfra-e2e-aws-ovn/1801221037195530240 is past the bootstrap phase, so the target group creation issue is fixed.

@r4f4
Copy link
Contributor Author

r4f4 commented Jun 13, 2024

The cluster in the altinfra-e2e-aws-ovn job is up:

time="2024-06-13T12:44:10Z" level=debug msg="Time elapsed per stage:"
time="2024-06-13T12:44:10Z" level=debug msg="       Infrastructure Pre-provisioning: 1s"
time="2024-06-13T12:44:10Z" level=debug msg="   Network-infrastructure Provisioning: 5m23s"
time="2024-06-13T12:44:10Z" level=debug msg="Post-network, pre-machine Provisioning: 30s"
time="2024-06-13T12:44:10Z" level=debug msg="                  Machine Provisioning: 30s"
time="2024-06-13T12:44:10Z" level=debug msg="                    Bootstrap Complete: 12m9s"
time="2024-06-13T12:44:10Z" level=debug msg="                                   API: 8m48s"
time="2024-06-13T12:44:10Z" level=debug msg="                     Bootstrap Destroy: 1m35s"
time="2024-06-13T12:44:10Z" level=debug msg="           Cluster Operators Available: 9m50s"
time="2024-06-13T12:44:10Z" level=debug msg="              Cluster Operators Stable: 50s"
time="2024-06-13T12:44:10Z" level=info msg="Time elapsed: 31m2s"

@sadasu
Copy link
Contributor

sadasu commented Jun 13, 2024

/approve

@r4f4
Copy link
Contributor Author

r4f4 commented Jun 13, 2024

/hold cancel
Most aws jobs already passed the install phase.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 972c722 and 2 for PR HEAD 8c53e55 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-secureboot 8c53e55 link false /test e2e-gcp-secureboot
ci/prow/e2e-aws-ovn-fips 8c53e55 link false /test e2e-aws-ovn-fips
ci/prow/e2e-azurestack 8c53e55 link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio mtulio mentioned this pull request Jun 13, 2024
Merged
@patrickdillon patrickdillon merged commit 4e33e34 into openshift:master Jun 13, 2024
31 of 35 checks passed
@openshift-ci-robot
Copy link
Contributor

@r4f4: Jira Issue OCPBUGS-34819: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34819 has been moved to the MODIFIED state.

In response to this:

This version brings in 2 important fixes:

  • Fix duplicated target group names
  • Fix reconciling load balancer in case of errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Jun 13, 2024

/cherry-pick release-4.16

@patrickdillon
Copy link
Contributor

/refresh

this never works but hey

@patrickdillon
Copy link
Contributor

/pony

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

@patrickdillon: pony image

In response to this:

/pony

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@patrickdillon
Copy link
Contributor

/cherry-pick release-4.16

@r4f4 r4f4 mentioned this pull request Jun 13, 2024
Merged
@r4f4
Copy link
Contributor Author

r4f4 commented Jun 14, 2024

For the record, these are the fixes and features included in this bump:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpei gpei Awaiting requested review from gpei

@barbacbd barbacbd Awaiting requested review from barbacbd

Assignees

@mtulio mtulio

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@r4f4 @openshift-ci-robot @openshift-cherrypick-robot @mtulio @sadasu @patrickdillon