OCPBUGS-37777: UPSTREAM: 6010: reassign err to prevent invalid return in KedaProvider GetExternalMetric

[maxcao13]

Fix panic in KedaProvider when getting metrics from Metrics Service if the gRPC Server connection is not established.
Cherry-pick of kedacore#6010

[maxcao13]

Also fixes a formatting issue with one of the list items in the CHANGELOG.md. Not sure if that's from upstream or from us :-)

[joelsmith]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, maxcao13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [joelsmith]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@maxcao13: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@maxcao13: Jira Issue OCPBUGS-37777 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Fix panic in KedaProvider when getting metrics from Metrics Service if the gRPC Server connection is not established.
Cherry-pick of kedacore#6010

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[maxcao13]

/refresh

[openshift-ci-robot]

@maxcao13: Jira Issue OCPBUGS-37777: All pull requests linked via external trackers have merged:

• openshift/kedacore-keda#33

Jira Issue OCPBUGS-37777 has been moved to the MODIFIED state.

In response to this:

Fix panic in KedaProvider when getting metrics from Metrics Service if the gRPC Server connection is not established.
Cherry-pick of kedacore#6010

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.