forked from brancz/kube-rbac-proxy
-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #43 from deads2k/authz
add hardcoded authorizer to approve /metrics for metrics scraper
- Loading branch information
Showing
5 changed files
with
242 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /* | ||
| Copyright 2021 Frederic Branczyk All rights reserved. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| // this is copied from library-go to avoid a hard dependency | ||
| package hardcodedauthorizer | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "k8s.io/apiserver/pkg/authorization/authorizer" | ||
| ) | ||
|
|
||
| type metricsAuthorizer struct{} | ||
|
|
||
| // GetUser() user.Info - checked | ||
| // GetVerb() string - checked | ||
| // IsReadOnly() bool - na | ||
| // GetNamespace() string - na | ||
| // GetResource() string - na | ||
| // GetSubresource() string - na | ||
| // GetName() string - na | ||
| // GetAPIGroup() string - na | ||
| // GetAPIVersion() string - na | ||
| // IsResourceRequest() bool - checked | ||
| // GetPath() string - checked | ||
| func (metricsAuthorizer) Authorize(ctx context.Context, a authorizer.Attributes) (authorized authorizer.Decision, reason string, err error) { | ||
| if a.GetUser() == nil { | ||
| return authorizer.DecisionNoOpinion, "", nil | ||
| } | ||
| if a.GetUser().GetName() != "system:serviceaccount:openshift-monitoring:prometheus-k8s" { | ||
| return authorizer.DecisionNoOpinion, "", nil | ||
| } | ||
| if !a.IsResourceRequest() && | ||
| a.GetVerb() == "get" && | ||
| a.GetPath() == "/metrics" { | ||
| return authorizer.DecisionAllow, "requesting metrics is allowed", nil | ||
| } | ||
|
|
||
| return authorizer.DecisionNoOpinion, "", nil | ||
| } | ||
|
|
||
| // NewHardCodedMetricsAuthorizer returns a hardcoded authorizer for checking metrics. | ||
| func NewHardCodedMetricsAuthorizer() *metricsAuthorizer { | ||
| return new(metricsAuthorizer) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| /* | ||
| Copyright 2021 Frederic Branczyk All rights reserved. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package hardcodedauthorizer | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| "k8s.io/apiserver/pkg/authentication/user" | ||
| "k8s.io/apiserver/pkg/authorization/authorizer" | ||
| ) | ||
|
|
||
| func TestAuthorizer(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| authorizer authorizer.Authorizer | ||
|
|
||
| shouldPass []authorizer.Attributes | ||
| shouldNoOpinion []authorizer.Attributes | ||
| }{ | ||
| { | ||
| name: "metrics", | ||
| authorizer: NewHardCodedMetricsAuthorizer(), | ||
| shouldPass: []authorizer.Attributes{ | ||
| authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "system:serviceaccount:openshift-monitoring:prometheus-k8s"}, Verb: "get", Path: "/metrics"}, | ||
| }, | ||
| shouldNoOpinion: []authorizer.Attributes{ | ||
| // wrong user | ||
| authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "other"}, Verb: "get", Path: "/metrics"}, | ||
| // wrong verb | ||
| authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "system:serviceaccount:openshift-monitoring:prometheus-k8s"}, Verb: "update", Path: "/metrics"}, | ||
|
|
||
| // wrong path | ||
| authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "system:serviceaccount:openshift-monitoring:prometheus-k8s"}, Verb: "get", Path: "/api"}, | ||
| }, | ||
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| for _, attr := range tt.shouldPass { | ||
| if decision, _, _ := tt.authorizer.Authorize(context.Background(), attr); decision != authorizer.DecisionAllow { | ||
| t.Errorf("incorrectly restricted %v", attr) | ||
| } | ||
| } | ||
|
|
||
| for _, attr := range tt.shouldNoOpinion { | ||
| if decision, _, _ := tt.authorizer.Authorize(context.Background(), attr); decision != authorizer.DecisionNoOpinion { | ||
| t.Errorf("incorrectly opinionated %v", attr) | ||
| } | ||
| } | ||
| }) | ||
| } | ||
| } |
106 changes: 106 additions & 0 deletions
106
vendor/k8s.io/apiserver/pkg/authorization/union/union.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters