[DNM] kubelet: debug phase logic for daemonset pods #705
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
@ehashman: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ehashman The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ehashman
force-pushed
the
test-phase-fix
branch
from
7148f24 to
b01e90c
Compare
|
@ehashman: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
ehashman
changed the title
ehashman
force-pushed
the
test-phase-fix
branch
from
b01e90c to
5115e9d
Compare
|
@ehashman: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/test e2e-gcp-upgrade |
1 similar comment
|
/test e2e-gcp-upgrade |
|
/test e2e-aws-upgrade |
ehashman
force-pushed
the
test-phase-fix
branch
from
5115e9d to
e9f4bc6
Compare
|
@ehashman: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/test e2e-gcp-upgrade |
|
@ehashman: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/test e2e-gcp-upgrade |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ehashman The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ehashman: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/test e2e-gcp-upgrade |
|
/test all |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test unit This causes a regression in the kubelet_test.go unit tests. Trying to decide if how I've implemented the fix is incorrect or if there's some other cleaning up that needs to happen elsewhere. |
|
@ehashman: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/test e2e-gcp-upgrade |
|
/test e2e-gcp-upgrade |
|
@ehashman: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/test e2e-gcp-upgrade |
|
@ehashman: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
| if pod.DeletionTimestamp == nil { | ||
| continue | ||
| } |
There was a problem hiding this comment.
I think I finally got it. This section here was preventing pods that didn't have a DeletionTimestamp set for some reason from getting an unknown termination set.
So, remove this check, and increment restart count by one if this is not set below.
|
@ehashman: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
| status := statuses[container.Name] | ||
| // if the status we're about to write indicates the default, the Waiting status will force this pod back into Pending. | ||
| // That isn't true, we know the pod is going away. | ||
| // That isn't true, we know the pod was restarted. |
There was a problem hiding this comment.
This is sort of the crux of the issue -- previously, this logic only toggled on termination, but it's possible for pods to need this logic on restart (e.g. daemonsets, node crash).
|
/test e2e-gcp-upgrade |
|
@ehashman: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Only 22 pods moved back to pending and the unit tests pass 🎉 🎉 |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
@ehashman: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Trying to see if this addresses Bug 1933760. Adds some debug logging to assist.