-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating openshift-enterprise-hyperkube images to be consistent with ART #934
Updating openshift-enterprise-hyperkube images to be consistent with ART #934
Conversation
@openshift-bot: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
bcf7fad
to
bdc6ec3
Compare
@openshift-bot: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
bdc6ec3
to
4341263
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/label backports/validated-commits
/remove-label backports/unvalidated-commits
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-bot, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test e2e-aws-downgrade |
/retest-required |
/test e2e-azure-upgrade |
/override ci/prow/e2e-agnostic-cmd |
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-agnostic-cmd In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-azure-upgrade |
3 similar comments
/test e2e-azure-upgrade |
/test e2e-azure-upgrade |
/test e2e-azure-upgrade |
/test e2e-azure-upgrade |
/retest-required |
/test k8s-e2e-gcp |
Updating openshift-enterprise-hyperkube images to be consistent with ART
TLDR:
Component owners, please ensure that this PR merges as it impacts the fidelity
of your CI signal. Patch-manager / leads, this PR is a no-op from a product
perspective -- feel free to manually apply any labels (e.g. bugzilla/valid-bug) to help the
PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is
to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test
to remove this tag and help the PR to merge.
Detail:
This repository is out of sync with the downstream product builds for this component.
One or more images differ from those being used by ART to create product builds. This
should be addressed to ensure that the component's CI testing is accurately
reflecting what customers will experience.
The information within the following ART component metadata is driving this alignment
request: openshift-enterprise-hyperkube.yml.
The vast majority of these PRs are opened because a different Golang version is being
used to build the downstream component. ART compiles most components with the version
of Golang being used by the control plane for a given OpenShift release. Exceptions
to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift
architecture team and communicated to the ART team.
Roles & Responsibilities:
tests OR that necessary metadata changes are reported to the ART team:
@release-artists
in
#aos-art
on Slack. If necessary, the changes required by this pull request can beintroduced with a separate PR opened by the component team. Once the repository is aligned,
this PR will be closed automatically.
any required labels to ensure the PR merges once tests are passing. Downstream builds
are already being built with these changes. Merging this PR only improves the fidelity
of our CI.
ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:
If you have any questions about this pull request, please reach out to
@art-team
in the#aos-art
coreos slack channel.