Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 1775: in ldapquery, validation out of bounds query should be case insensitive as ldap is. #1756

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

germanparente
Copy link

Any compare operation in ldap should be case insensitive.

This is to fix a well known issue in oc groups sync command that is comparing base dn to a dn and showing out of bounds if the compare operation fails.

@openshift-ci openshift-ci bot requested review from deads2k and ibihim July 7, 2024 11:02
@germanparente
Copy link
Author

/assign

@dusk125
Copy link
Contributor

dusk125 commented Jul 9, 2024

@germanparente can you add a test case please?

@germanparente
Copy link
Author

I will do. Thanks for reviewing

@dusk125
Copy link
Contributor

dusk125 commented Jul 18, 2024

I validated that the added test fails without the fix, and with the fix, it passes
/lgtm
Passing to @deads2k for final review

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2024
Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dusk125, germanparente
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

@germanparente: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants