-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue 1775: in ldapquery, validation out of bounds query should be case insensitive as ldap is. #1756
base: master
Are you sure you want to change the base?
Conversation
…ld be case insensitive as ldap is
/assign |
@germanparente can you add a test case please? |
I will do. Thanks for reviewing |
I validated that the added test fails without the fix, and with the fix, it passes |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dusk125, germanparente The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@germanparente: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Any compare operation in ldap should be case insensitive.
This is to fix a well known issue in oc groups sync command that is comparing base dn to a dn and showing out of bounds if the compare operation fails.