Skip to content

Commit

Permalink
fix: add check of correct lv state of thin-pool when vg is already cr…
Browse files Browse the repository at this point in the history
…eated
  • Loading branch information
jakobmoellerdev committed Aug 14, 2023
1 parent fc2a919 commit 5ff455e
Show file tree
Hide file tree
Showing 6 changed files with 452 additions and 16 deletions.
153 changes: 153 additions & 0 deletions pkg/vgmanager/lv_attr.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,153 @@
package vgmanager

import "fmt"

// LvAttr has mapped lv_attr information, see https://linux.die.net/man/8/lvs
// It is a complete parsing of the entire attribute byte flags that is attached to each LV.
// This is useful when attaching logic to the state of an LV as the state of an LV can be determined
// from the Attributes, e.g. for determining wether an LV is considered a Thin-Pool or not.
type LvAttr struct {
VolumeType
Permissions
AllocationPolicy
Minor
State
Open
OpenTarget
Zero
Partial
}

func ParsedLvAttr(raw string) (LvAttr, error) {
if len(raw) != 10 {
return LvAttr{}, fmt.Errorf("%s is an invalid length lv_attr", raw)
}
return LvAttr{
VolumeType(raw[0]),
Permissions(raw[1]),
AllocationPolicy(raw[2]),
Minor(raw[3]),
State(raw[4]),
Open(raw[5]),
OpenTarget(raw[6]),
Zero(raw[7]),
Partial(raw[8]),
}, nil
}

func (l LvAttr) String() string {
return fmt.Sprintf(
"%c%c%c%c%c%c%c%c%c",
l.VolumeType,
l.Permissions,
l.AllocationPolicy,
l.Minor,
l.State,
l.Open,
l.OpenTarget,
l.Zero,
l.Partial,
)
}

type VolumeType rune

const (
VolumeTypeMirrored VolumeType = 'm'
VolumeTypeMirroredNoInitialSync VolumeType = 'M'
VolumeTypeOrigin VolumeType = 'o'
VolumeTypeOriginWithMergingSnapshot VolumeType = 'O'
VolumeTypeRAID VolumeType = 'r'
VolumeTypeRAIDNoInitialSync VolumeType = 'R'
VolumeTypeSnapshot VolumeType = 's'
VolumeTypeMergingSnapshot VolumeType = 'S'
VolumeTypePVMove VolumeType = 'p'
VolumeTypeVirtual VolumeType = 'v'
VolumeTypeMirrorOrRAIDImage VolumeType = 'i'
VolumeTypeMirrorOrRAIDImageOutOfSync VolumeType = 'I'
VolumeTypeMirrorLogDevice VolumeType = 'l'
VolumeTypeUnderConversion VolumeType = 'c'
VolumeTypeThinVolume VolumeType = 'V'
VolumeTypeThinPool VolumeType = 't'
VolumeTypeThinPoolData VolumeType = 'T'
VolumeTypeThinPoolMetadata VolumeType = 'e'
VolumeTypeNone VolumeType = '-'
)

type Permissions rune

const (
PermissionsWriteable Permissions = 'w'
PermissionsReadOnly Permissions = 'r'
PermissionsReadOnlyActivationOfNonReadOnlyVolume Permissions = 'R'
PermissionsNone Permissions = '-'
)

type AllocationPolicy rune

const (
AllocationPolicyAnywhere AllocationPolicy = 'a'
AllocationPolicyAnywhereLocked AllocationPolicy = 'A'
AllocationPolicyContiguous AllocationPolicy = 'c'
AllocationPolicyContiguousLocked AllocationPolicy = 'C'
AllocationPolicyInherited AllocationPolicy = 'i'
AllocationPolicyInheritedLocked AllocationPolicy = 'I'
AllocationPolicyCling AllocationPolicy = 'l'
AllocationPolicyClingLocked AllocationPolicy = 'L'
AllocationPolicyNormal AllocationPolicy = 'n'
AllocationPolicyNormalLocked AllocationPolicy = 'N'
AllocationPolicyNone = '-'
)

type Minor rune

const (
MinorTrue Minor = 'm'
MinorFalse Minor = '-'
)

type State rune

const (
StateActive State = 'a'
StateSuspended = 's'
StateInvalidSnapshot = 'I'
StateSuspendedSnapshot = 'S'
StateSnapshotMergeFailed = 'm'
StateSuspendedSnapshotMergeFailed = 'M'
StateMappedDevicePresentWithoutTables = 'd'
StateMappedDevicePresentWithInactiveTables = 'i'
StateNone = '-'
)

type Open rune

const (
OpenTrue Open = 'o'
OpenFalse Open = '-'
)

type OpenTarget rune

const (
OpenTargetMirror = 'm'
OpenTargetRaid = 'r'
OpenTargetSnapshot = 's'
OpenTargetThin = 't'
OpenTargetUnknown = 'u'
OpenTargetVirtual = 'v'
)

type Zero rune

const (
ZeroTrue Zero = 'z'
ZeroFalse Zero = '-'
)

type Partial rune

const (
PartialTrue = 'p'
PartialFalse = '-'
)
62 changes: 62 additions & 0 deletions pkg/vgmanager/lv_attr_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
package vgmanager

import (
"fmt"
"testing"

"github.com/stretchr/testify/assert"
)

func TestParsedLvAttr(t *testing.T) {
type args struct {
raw string
}
tests := []struct {
name string
args args
want LvAttr
wantErr assert.ErrorAssertionFunc
}{
{
"RAID Config without Initial Sync",
args{raw: "Rwi-a-r---"},
LvAttr{
VolumeType: VolumeTypeRAIDNoInitialSync,
Permissions: PermissionsWriteable,
AllocationPolicy: AllocationPolicyInherited,
Minor: MinorFalse,
State: StateActive,
Open: OpenFalse,
OpenTarget: OpenTargetRaid,
Zero: ZeroFalse,
Partial: PartialFalse,
},
assert.NoError,
},
{
"ThinPool with Zeroing",
args{raw: "twi-a-tz--"},
LvAttr{
VolumeType: VolumeTypeThinPool,
Permissions: PermissionsWriteable,
AllocationPolicy: AllocationPolicyInherited,
Minor: MinorFalse,
State: StateActive,
Open: OpenFalse,
OpenTarget: OpenTargetThin,
Zero: ZeroTrue,
Partial: PartialFalse,
},
assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got, err := ParsedLvAttr(tt.args.raw)
if !tt.wantErr(t, err, fmt.Sprintf("ParsedLvAttr(%v)", tt.args.raw)) {
return
}
assert.Equalf(t, tt.want, got, "ParsedLvAttr(%v)", tt.args.raw)
})
}
}
11 changes: 6 additions & 5 deletions pkg/vgmanager/lvm.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,12 @@ type pvsOutput struct {
type lvsOutput struct {
Report []struct {
Lv []struct {
Name string `json:"lv_name"`
VgName string `json:"vg_name"`
PoolName string `json:"pool_lv"`
LvAttr string `json:"lv_attr"`
LvSize string `json:"lv_size"`
Name string `json:"lv_name"`
VgName string `json:"vg_name"`
PoolName string `json:"pool_lv"`
LvAttr string `json:"lv_attr"`
LvSize string `json:"lv_size"`
MetadataPercent string `json:"metadata_percent"`
} `json:"lv"`
} `json:"report"`
}
Expand Down
81 changes: 70 additions & 11 deletions pkg/vgmanager/vgmanager_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@ import (
)

const (
ControllerName = "vg-manager"
DefaultChunkSize = "128"
reconcileInterval = 1 * time.Minute
ControllerName = "vg-manager"
DefaultChunkSize = "128"
reconcileInterval = 1 * time.Minute
metadataWarningPercentage = 95
)

var (
Expand Down Expand Up @@ -181,21 +182,31 @@ func (r *VGReconciler) reconcile(ctx context.Context, volumeGroup *lvmv1alpha1.L
}
}

if devicesExist {
r.Log.Info("all the available devices are attached to the volume group", "VGName", volumeGroup.Name)
if statuserr := r.setVolumeGroupReadyStatus(ctx, volumeGroup.Name); statuserr != nil {
r.Log.Error(statuserr, "failed to update status", "VGName", volumeGroup.Name)
if !devicesExist {
err := fmt.Errorf("no available devices found for volume group")
r.Log.Error(err, err.Error(), "VGName", volumeGroup.Name)
if statuserr := r.setVolumeGroupFailedStatus(ctx, volumeGroup.Name, err.Error()); statuserr != nil {
r.Log.Error(statuserr, "failed to update status", "name", volumeGroup.Name)
return reconcileAgain, statuserr
}
} else {
errMsg := "no available devices found for volume group"
r.Log.Error(fmt.Errorf(errMsg), errMsg, "VGName", volumeGroup.Name)
if statuserr := r.setVolumeGroupFailedStatus(ctx, volumeGroup.Name, errMsg); statuserr != nil {
return reconcileAgain, err
}

if err := r.validateLVs(volumeGroup); err != nil {
err := fmt.Errorf("error while validating logical volumes in existing volume group: %w", err)
r.Log.Error(err, err.Error(), "VGName", volumeGroup.Name)
if statuserr := r.setVolumeGroupFailedStatus(ctx, volumeGroup.Name, err.Error()); statuserr != nil {
r.Log.Error(statuserr, "failed to update status", "name", volumeGroup.Name)
return reconcileAgain, statuserr
}
return reconcileAgain, err
}

r.Log.Info("all the available devices are attached to the volume group", "VGName", volumeGroup.Name)
if statuserr := r.setVolumeGroupReadyStatus(ctx, volumeGroup.Name); statuserr != nil {
r.Log.Error(statuserr, "failed to update status", "VGName", volumeGroup.Name)
return reconcileAgain, statuserr
}
return reconcileAgain, nil
}

Expand Down Expand Up @@ -370,6 +381,54 @@ func (r *VGReconciler) processDelete(ctx context.Context, volumeGroup *lvmv1alph
return nil
}

// validateLVs verifies that all lvs that should have been created in the volume group are present and
// in their correct state
func (r *VGReconciler) validateLVs(volumeGroup *lvmv1alpha1.LVMVolumeGroup) error {
// If we don't have a ThinPool, VG Manager has no authority about the top Level LVs inside the VG, but TopoLVM
if volumeGroup.Spec.ThinPoolConfig == nil {
return nil
}

resp, err := GetLVSOutput(r.executor, volumeGroup.Name)
if err != nil {
return fmt.Errorf("could not get logical volumes found inside volume group, volume group content is degraded or corrupt: %w", err)
}

for _, report := range resp.Report {
for _, lv := range report.Lv {
if lv.Name != volumeGroup.Spec.ThinPoolConfig.Name {
continue
}
lvAttr, err := ParsedLvAttr(lv.LvAttr)
if err != nil {
return fmt.Errorf("could not parse lv_attr from logical volume %s: %w", lv.Name, err)
}
if lvAttr.VolumeType != VolumeTypeThinPool {
return fmt.Errorf("found logical volume in volume group that is not of type Thin-Pool, "+
"even though there is a Thin-Pool configured: %s, lv_attr: %s,"+
"this is most likely a corruption of the thin pool or a setup gone wrong",
string(lvAttr.VolumeType), lvAttr)
}

if lvAttr.State != StateActive {
return fmt.Errorf("found inactive logical volume, maybe external repairs are formed or there is another"+
"entity conflicting with vg-manager, cannot proceed until volume is activated again: lv_attr: %s", lvAttr)
}
metadataPercentage, err := strconv.ParseFloat(lv.MetadataPercent, 32)
if err != nil {
return fmt.Errorf("could not ensure metadata percentage of LV due to a parsing error: %w", err)
}
if metadataPercentage > metadataWarningPercentage {
return fmt.Errorf("metadata partition is over %v percent filled and LVM Metadata Overflows cannot be recovered"+
"you should manually extend the metadata_partition or you will risk data loss: metadata_percent: %v", metadataPercentage, lv.MetadataPercent)
}

r.Log.Info("confirmed created logical volume has correct attributes", "lv_attr", lvAttr.String())
}
}
return nil
}

func (r *VGReconciler) addThinPoolToVG(vgName string, config *lvmv1alpha1.ThinPoolConfig) error {
resp, err := GetLVSOutput(r.executor, vgName)
if err != nil {
Expand Down
Loading

0 comments on commit 5ff455e

Please sign in to comment.