Merge pull request #446 from suleymanakbas91/activate

OCPVE-726: Activate inactive logical volumes

internal/controllers/vgmanager/controller.go

@@ -482,8 +482,12 @@ func (r *Reconciler) validateLVs(ctx context.Context, volumeGroup *lvmv1alpha1.L
 			}
 
 			if lvAttr.State != StateActive {
-				return fmt.Errorf("found inactive logical volume, maybe external repairs are necessary/already happening or there is another"+
-					"entity conflicting with vg-manager, cannot proceed until volume is activated again: lv_attr: %s", lvAttr)
+				//If inactive, try activating it
+				err := r.LVM.ActivateLV(lv.Name, volumeGroup.Name)
+				if err != nil {
+					return fmt.Errorf("could not activate the inactive logical volume, maybe external repairs are necessary/already happening or there is another"+
+						"entity conflicting with vg-manager, cannot proceed until volume is activated again: lv_attr: %s", lvAttr)
+				}
 			}
 			metadataPercentage, err := strconv.ParseFloat(lv.MetadataPercent, 32)
 			if err != nil {

internal/controllers/vgmanager/controller_test.go

@@ -243,7 +243,7 @@ func testMockedBlockDeviceOnHost(ctx context.Context) {
 		thinPool = lvm.LogicalVolume{
 			Name:            vg.Spec.ThinPoolConfig.Name,
 			VgName:          vg.GetName(),
-			LvAttr:          "twi-a-tz--",
+			LvAttr:          "twi---tz--",
 			LvSize:          "1.0G",
 			MetadataPercent: "10.0",
 		}
@@ -256,6 +256,7 @@ func testMockedBlockDeviceOnHost(ctx context.Context) {
 			Lv: []lvm.LogicalVolume{thinPool},
 		}}}, nil).Once()
 		instances.LVM.EXPECT().ListVGs().Return([]lvm.VolumeGroup{createdVG}, nil).Twice()
+		instances.LVM.EXPECT().ActivateLV(thinPool.Name, vg.GetName()).Return(nil).Once()
 	})
 
 	By("triggering the next reconciliation after the creation of the thin pool", func() {
@@ -284,7 +285,7 @@ func testMockedBlockDeviceOnHost(ctx context.Context) {
 	})
 
 	var oldReadyGeneration int64
-	By("verifiyng the VGStatus is now ready", func() {
+	By("verifying the VGStatus is now ready", func() {
 		checkDistributedEvent(corev1.EventTypeNormal, "all the available devices are attached to the volume group")
 		Expect(instances.client.Get(ctx, client.ObjectKeyFromObject(nodeStatus), nodeStatus)).To(Succeed())
 		Expect(nodeStatus.Spec.LVMVGStatus).ToNot(BeEmpty())
@@ -326,6 +327,7 @@ func testMockedBlockDeviceOnHost(ctx context.Context) {
 		instances.LVM.EXPECT().ListLVs(vg.GetName()).Return(&lvm.LVReport{Report: []lvm.LVReportItem{{
 			Lv: []lvm.LogicalVolume{thinPool},
 		}}}, nil).Once()
+		instances.LVM.EXPECT().ActivateLV(thinPool.Name, createdVG.Name).Return(nil).Once()
 	})
 
 	By("triggering the verification reconcile that should confirm the ready state", func() {

internal/controllers/vgmanager/lvm/lvm.go

@@ -102,6 +102,7 @@ type LVM interface {
 	LVExists(lvName, vgName string) (bool, error)
 	CreateLV(lvName, vgName string, sizePercent int) error
 	ExtendLV(lvName, vgName string, sizePercent int) error
+	ActivateLV(lvName, vgName string) error
 	DeleteLV(lvName, vgName string) error
 }
 
@@ -452,6 +453,19 @@ func (hlvm *HostLVM) ExtendLV(lvName, vgName string, sizePercent int) error {
 	return nil
 }
 
+// ActivateLV activates the logical volume
+func (hlvm *HostLVM) ActivateLV(lvName, vgName string) error {
+	lv := fmt.Sprintf("%s/%s", vgName, lvName)
+
+	// deactivate logical volume
+	_, err := hlvm.ExecuteCommandWithOutputAsHost(lvChangeCmd, "-ay", lv)
+	if err != nil {
+		return fmt.Errorf("failed to activate thin pool %q in volume group %q. %w", lvName, vgName, err)
+	}
+
+	return nil
+}
+
 func (hlvm *HostLVM) execute(v interface{}, args ...string) error {
 	output, err := hlvm.ExecuteCommandWithOutputAsHost(lvmCmd, args...)
 	if err != nil {