Skip to content

Commit

Permalink
Merge pull request #108 from leelavg/stream-image
Browse files Browse the repository at this point in the history
ci: build combined dockerfile as part of CI
  • Loading branch information
nbalacha authored Feb 15, 2022
2 parents f7b7b1b + 34313af commit 8426354
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docker-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ jobs:
key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }}

- name: Build operator docker image
run: make docker-build
run: make docker-build-combined
2 changes: 1 addition & 1 deletion Dockerfile.combined
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o vgmanager cmd/vgmanager
RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o metricsexporter cmd/metricsexporter/exporter.go

# vgmanager needs 'nsenter' and other basic linux utils to correctly function
FROM centos:stream8
FROM quay.io/centos/centos:stream8

# Install required utilities
RUN dnf install -y openssl && dnf clean all
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ docker-build: test ## Build docker image with the manager.
docker-build-vgmanager: ## Build docker image with vgmanager.
docker build -f Dockerfile.vgmanager -t ${VGMANAGER_IMG} .

docker-build-combined: ## Build docker image with manager and vgmanager
docker-build-combined: test ## Build docker image with manager and vgmanager
docker build -f Dockerfile.combined -t ${IMG} .

docker-push: ## Push docker image with the manager.
Expand Down

0 comments on commit 8426354

Please sign in to comment.