Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update go 1.16 to 1.17 #129

Merged
merged 1 commit into from
Mar 21, 2022
Merged

build: update go 1.16 to 1.17 #129

merged 1 commit into from
Mar 21, 2022

Conversation

iamniting
Copy link
Member

Signed-off-by: Nitin Goyal nigoyal@redhat.com

@iamniting
build: update go 1.16 to 1.17
5d3ae3e 
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@leelavg
Copy link
Contributor

leelavg commented Mar 16, 2022

@iamniting is it tested for PVC operations or need to be tested?

leelavg
leelavg reviewed Mar 16, 2022
View reviewed changes
go.mod
@@ -20,3 +20,78 @@ require (
sigs.k8s.io/controller-runtime v0.10.2
sigs.k8s.io/yaml v1.2.0
)

require (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • any idea why this was factored out into a new require block and no changes to go.sum?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I ran go mod tidy which did this change, and nothing in the go.mod file. As they are all indirect deps we might already have all of them in the go.sum

@iamniting
Copy link
Member Author

@iamniting is it tested for PVC operations or need to be tested?

Not yet

@iamniting
Copy link
Member Author

@iamniting is it tested for PVC operations or need to be tested?

Not yet

Tested it out and it works well

┌─[nigoyalॐ nigoyal ~/code/go/src/github.com/red-hat-storage/lvm-operator  golang]
└──╼$ oc get pods
NAME                                               READY   STATUS    RESTARTS   AGE
app-file                                           1/1     Running   0          27s
lvm-operator-controller-manager-547b5bbb46-ml9d4   3/3     Running   0          4m5s
topolvm-controller-778cfb5d54-8xfln                4/4     Running   0          3m5s
topolvm-node-bjhtk                                 4/4     Running   0          3m5s
vg-manager-6ffc2                                   1/1     Running   0          3m5s

┌─[nigoyalॐ nigoyal ~/code/go/src/github.com/red-hat-storage/lvm-operator  golang]
└──╼$ oc get pvc
NAME           STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
lvm-file-pvc   Bound    pvc-39711d19-4f15-448c-ab0e-9a28c3e58732   5Gi        RWO            odf-lvm-vg1    65s

leelavg
leelavg approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, leelavg, nbalacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2022
@nbalacha nbalacha merged commit 2806df6 into openshift:main Mar 21, 2022
@iamniting iamniting deleted the golang branch April 13, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leelavg leelavg leelavg approved these changes

@nbalacha nbalacha nbalacha approved these changes

Assignees

@nbalacha nbalacha

@leelavg leelavg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamniting @leelavg @nbalacha