Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

must-gather: add Makefile target to build must-gather image #138

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

agarwal-mudit
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@agarwal-mudit agarwal-mudit requested a review from nbalacha March 30, 2022 11:59
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
add Makefile target for lvm-must-gather

Signed-off-by: Mudit Agarwal <muagarwa@redhat.com>
Adding instructions to create a must-gather image.

Signed-off-by: Mudit Agarwal <muagarwa@redhat.com>
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, leelavg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3e00b44 into openshift:main Mar 31, 2022
@agarwal-mudit agarwal-mudit deleted the make branch April 1, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants