Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ensureCreated of lvmVG via returning an error #139

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

iamniting
Copy link
Member

The func does not return an error if there is an error and always return
nil. Fix the same via returning and error if there is a failure.

Signed-off-by: Nitin Goyal nigoyal@redhat.com

@iamniting iamniting requested a review from nbalacha April 1, 2022 11:52
@iamniting iamniting requested a review from nbalacha April 4, 2022 10:31
The func does not return an error if there is an error and always return
nil. Fix the same via returning and error if there is a failure.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, nbalacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit 41db655 into openshift:main Apr 4, 2022
@iamniting iamniting deleted the lvm_volumegroup branch April 13, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants