e2e: added make target to install ginkgo #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riya-singhal31
force-pushed
the
ginkgo-install
branch
2 times, most recently
from
c8ae881 to
144211e
Compare
|
riya-singhal31
force-pushed
the
ginkgo-install
branch
from
144211e to
bcd682f
Compare
Updated |
nbalacha
reviewed
Apr 5, 2022
Makefile
Outdated
| @@ -310,6 +315,6 @@ LVM_OPERATOR_UNINSTALL ?= true | |||
| # Build and run lvm tests. | |||
| e2e-test: | |||
There was a problem hiding this comment.
Suggested change
| e2e-test: | |
| e2e-test: ginkgo |
There was a problem hiding this comment.
Please remove the ginkgo package from your system and try running e2e-test
There was a problem hiding this comment.
Thanks Nithya for the suggestion,
It is working and is able to install ginkgo if not already installed.
It creates a ginkgo file inside the bin package if we already dont have that.
Added make target to install ginkgo and gomega Signed-off-by: riya-singhal31 <riyasinghalji@gmail.com>
riya-singhal31
force-pushed
the
ginkgo-install
branch
from
bcd682f to
2a5c5cd
Compare
|
/assign @nbalacha |
nbalacha
approved these changes
Apr 6, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nbalacha, riya-singhal31 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added make target to install ginkgo and gomega
Signed-off-by: riya-singhal31 riyasinghalji@gmail.com