test: added test to validate the LVMO resources #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbalacha
suggested changes
Apr 13, 2022
e2e/lvm/lvm_suite_test.go
Outdated
| Context("Run a dummy test", func() { | ||
| // Test to validate all the resources created by LVMO. | ||
| var _ = Describe("Validation test", func() { | ||
| Context("Validate all the resources", func() { |
There was a problem hiding this comment.
Suggested change
| Context("Validate all the resources", func() { | |
| Context("Validate LVMCluster reconciliation", func() { |
riya-singhal31
force-pushed
the
validation-test
branch
2 times, most recently
from
54adb4b to
b17be50
Compare
nbalacha
reviewed
Apr 13, 2022
e2e/validation.go
Outdated
| lvmVolumeGroupName = "vg1" | ||
| storageClassName = "odf-lvm-vg1" | ||
| csiDriverName = "topolvm.cybozu.com" | ||
| daemonSetName = "topolvm-node" |
There was a problem hiding this comment.
Suggested change
| daemonSetName = "topolvm-node" | |
| topolvmNodeDaemonSetName = "topolvm-node" |
e2e/validation.go
Outdated
| storageClassName = "odf-lvm-vg1" | ||
| csiDriverName = "topolvm.cybozu.com" | ||
| daemonSetName = "topolvm-node" | ||
| deploymentName = "topolvm-controller" |
There was a problem hiding this comment.
Suggested change
| deploymentName = "topolvm-controller" | |
| topolvmCtrlDeploymentName = "topolvm-controller" |
riya-singhal31
force-pushed
the
validation-test
branch
from
b17be50 to
94df1ee
Compare
nbalacha
reviewed
Apr 13, 2022
e2e/validation.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| timeout = time.Second * 10 |
There was a problem hiding this comment.
You might need a larger timeout here. Maybe 30 s?
There was a problem hiding this comment.
It's working fine for 10 s. Should I still change it to 30?
nbalacha
reviewed
Apr 13, 2022
riya-singhal31
force-pushed
the
validation-test
branch
8 times, most recently
from
b691658 to
f6a879c
Compare
|
/retest |
riya-singhal31
force-pushed
the
validation-test
branch
5 times, most recently
from
76200a4 to
3b62176
Compare
nbalacha
suggested changes
Apr 18, 2022
e2e/validation.go
Outdated
| func ValidateResources() error { | ||
|
|
||
| // Validate Storage class | ||
| err := ValidateStorageClass() |
There was a problem hiding this comment.
Change the order here to match the order in the LVMCluster reconcile function:
- CSI Driver
- Topolvm controller
- vg manager
- LVMVolumeGroup
- topolvm node
- Storageclass
// Validate CSI Driver
err := ValidateCSIDriver()
if err != nil {
return err
}
//Validate TopoLVM Controller
err = ValidateTopolvmController()
if err != nil {
return err
}
// Validate VG Manager Daemonset
err = ValidateVGManager()
if err != nil {
return err
}
// Validate LVMVg
err = ValidateLVMvg()
if err != nil {
return err
}
// Validate Topolvm node
err = ValidateTopolvmNode()
if err != nil {
return err
}
// Validate Storage class
err = ValidateStorageClass()
if err != nil {
return err
}
e2e/validation.go
Outdated
Comment on lines
77
to
71
| func ValidateTopolvmNode() error { | ||
| ds := appsv1.DaemonSet{} | ||
| Eventually(func() bool { | ||
| err := DeployManagerObj.GetCrClient().Get(context.TODO(), types.NamespacedName{Name: topolvmNodeDaemonSetName, Namespace: InstallNamespace}, &ds) | ||
| if err != nil { | ||
| debug("TopoLVM Node: %v", err) | ||
| return false | ||
| } | ||
| return true | ||
| }, timeout, interval).Should(BeTrue()) | ||
| debug("TopoLVM node found\n") |
There was a problem hiding this comment.
Suggested change
| func ValidateTopolvmNode() error { | |
| ds := appsv1.DaemonSet{} | |
| Eventually(func() bool { | |
| err := DeployManagerObj.GetCrClient().Get(context.TODO(), types.NamespacedName{Name: topolvmNodeDaemonSetName, Namespace: InstallNamespace}, &ds) | |
| if err != nil { | |
| debug("TopoLVM Node: %v", err) | |
| return false | |
| } | |
| return true | |
| }, timeout, interval).Should(BeTrue()) | |
| debug("TopoLVM node found\n") | |
| func ValidateTopolvmNode() error { | |
| ds := appsv1.DaemonSet{} | |
| Eventually(func() bool { | |
| debug("%s\n", "Starting function - topolvmnode") | |
| err := DeployManagerObj.GetCrClient().Get(context.TODO(), types.NamespacedName{Name: topolvmNodeDaemonSetName, Namespace: InstallNamespace}, &ds) | |
| if err != nil { | |
| debug("topolvmNode : %s\n", err.Error()) | |
| return false | |
| } | |
| return ds.Status.DesiredNumberScheduled == ds.Status.NumberReady | |
| }, timeout, interval).Should(BeTrue()) |
riya-singhal31
force-pushed
the
validation-test
branch
from
3b62176 to
27fe12b
Compare
|
/test lvm-operator-bundle-e2e-aws |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
riya-singhal31
force-pushed
the
validation-test
branch
from
27fe12b to
d71bbfb
Compare
openshift-ci
bot
added
the
needs-rebase
riya-singhal31
force-pushed
the
validation-test
branch
from
d71bbfb to
e559cc0
Compare
openshift-ci
bot
removed
the
needs-rebase
riya-singhal31
force-pushed
the
validation-test
branch
from
e559cc0 to
94570df
Compare
nbalacha
reviewed
Apr 20, 2022
e2e/validation.go
Outdated
| return err == nil | ||
| }, timeout, interval).Should(BeTrue()) | ||
|
|
||
| debug("depoloyment found\n") |
There was a problem hiding this comment.
Suggested change
| debug("depoloyment found\n") | |
| debug("topolvm-controller deployment found\n") |
This test validates all the resources created by LVMO. Signed-off-by: riya-singhal31 <riyasinghalji@gmail.com>
riya-singhal31
force-pushed
the
validation-test
branch
from
94570df to
571bac0
Compare
|
@riya-singhal31: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
nbalacha
approved these changes
Apr 20, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nbalacha, riya-singhal31 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test validates all the resources created by LVMO
Signed-off-by: riya-singhal31 riyasinghalji@gmail.com