-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds alerts for thin pool usage #151
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be an issue with the percentages displayed in the messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some values are not right. We have to correct it in the libsonnet file
- "alert": "ThinPoolMetaDataUsageAtThresholdCritical" | ||
"annotations": | ||
"description": "Thin pool metadata ultilization in the VolumeGroup is critically full. Data deletion or thin pool expansion is required." | ||
"message": "Thin Pool metadata utilization in the VolumeGroup {{ $labels.device_class }} has crossed 8500 % on node {{ $labels.node }}. Free up some space or expand the thin pool immediately." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"message": "Thin Pool metadata utilization in the VolumeGroup {{ $labels.device_class }} has crossed 8500 % on node {{ $labels.node }}. Free up some space or expand the thin pool immediately." | |
"message": "Thin Pool metadata utilization in the VolumeGroup {{ $labels.device_class }} has crossed 85 % on node {{ $labels.node }}. Free up some space or expand the thin pool immediately." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. Also marking other similar comments are resolved.
@aruniiird: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adds alerts for thin pool data and metadata usage. Provides near full (75%) and critical (85%) usage alerts. Signed-off-by: Santosh Pillai <sapillai@redhat.com>
/retest |
@sp98: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
- "alert": "ThinPoolDataUsageAtThresholdCritical" | ||
"annotations": | ||
"description": "Thin pool in the VolumeGroup is critically full. Data deletion or thin pool expansion is required." | ||
"message": "Thin Pool data utilization in the VolumeGroup {{ $labels.device_class }} has crossed 85 % on node {{ $labels.node }}. Free up some space or expand the thin pool immediately." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this generated by the jsonnet? I don't see any changes to the libsonnet file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. These changes are in the monitoring/alerts/vgalerts.libsonnet
file.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nbalacha, sp98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds alerts for thin pool data and metadata usage.
Provides near full (75%) and critical (85%) usage alerts.
Note: We don't have thin pool name in the alerts since topolvm does not provide it as of now. But since we support only one thin pool per volume group, current alerts should suffice (IMO).
We can update it to include thin pool names once topolvm shows thin pool name in the metric labels.
Tested with lower thresholds.
Signed-off-by: Santosh Pillai sapillai@redhat.com