Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e: added thin pool configuration to lvm cluster used by e2e tests #156

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

riya-singhal31
Copy link
Contributor

@riya-singhal31 riya-singhal31 commented Apr 19, 2022

Updated the sample LVMCluster CR used by e2e tests with the thin pool configuration.

Signed-off-by: riya-singhal31 riyasinghalji@gmail.com

@riya-singhal31
Copy link
Contributor Author

/assign @nbalacha

Copy link
Contributor

@sp98 sp98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Please update the PR title, description and commit to highlight that changes are done for the sample lvm cluster used in e2e tests.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
Updated the LVMCluster CR used by e2e tests with the thin pool configuration.

Signed-off-by: riya-singhal31 <riyasinghalji@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@riya-singhal31 riya-singhal31 changed the title fix: added thin pool configuration to lvm cluster fix: added thin pool configuration to lvm cluster used by e2e tests Apr 19, 2022
@riya-singhal31 riya-singhal31 changed the title fix: added thin pool configuration to lvm cluster used by e2e tests fix e2e: added thin pool configuration to lvm cluster used by e2e tests Apr 19, 2022
@riya-singhal31
Copy link
Contributor Author

lgtm. Please update the PR title, description and commit to highlight that changes are done for the sample lvm cluster used in e2e tests.

Updated

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nbalacha, riya-singhal31, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2022
@openshift-merge-robot openshift-merge-robot merged commit 52c43da into openshift:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants