build: always generate fresh bundle #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
operator-sdk does not delete unnecessary files while generating a bundle, It just overwrites the required ones and we end up having resources which is not required anymore. Resolve the same via removing the bundle directory before generating a bundle. Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
|
Outputs after my testing |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
I wanted to test this again after cleaning up all resources which OLM does not clean up. and it is working properly. /hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
nbalacha
approved these changes
Apr 29, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, leelavg, nbalacha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator-sdk does not delete unnecessary files while generating
a bundle, It just overwrites the required ones and we end up having
resources which is not required anymore. Resolve the same via removing
the bundle directory before generating a bundle.
Signed-off-by: Nitin Goyal nigoyal@redhat.com