Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send vg alerts only when thin pool alerts are also triggered #205

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

sp98
Copy link
Contributor

@sp98 sp98 commented Jun 7, 2022

Trigger VolumeGroupUsage alerts only if actual size is occupied via the thin pool.
VolumeGroupUsageAtThresholdNearFull will be sent when used VG size and
thin pool size exceeds 75%.

VolumeGroupUsageAtThresholdCritical will be sent when VG size and thin
pool size exceeds 85%.

Testing

Current behavior: size-percent is 90

sh-4.4# vgs
  VG  #PV #LV #SN Attr   VSize  VFree
  vg3   1   1   0 wz--n- <1.46t 149.04g
sh-4.4# lvs
  LV          VG  Attr       LSize  Pool Origin Data%  Meta%  Move Log Cpy%Sync Convert
  thin-pool-3 vg3 twi-a-tz-- <1.31t             0.00   9.94
  • VG critical alert trigger even though thin pool is not using any real space.
    Screenshot from 2022-06-13 11-40-25

Behavior after this PR:

  • size percent is 90
sh-4.4# vgs
  VG  #PV #LV #SN Attr   VSize  VFree  
  vg4   1   1   0 wz--n- <1.46t 149.04g
sh-4.4# lvs
  LV          VG  Attr       LSize  Pool Origin Data%  Meta%  Move Log Cpy%Sync Convert
  thin-pool-4 vg4 twi-a-tz-- <1.31t             0.00   9.94                            
sh-4.4# 
  • No VG critical alert triggered.

Screenshot from 2022-06-13 12-22-38

  • Thin pool used data bytes cross 85%
sh-4.4# vgs
  VG  #PV #LV #SN Attr   VSize  VFree  
  vg4   1   2   0 wz--n- <1.46t 149.04g
sh-4.4# lvs
  LV                                   VG  Attr       LSize  Pool        Origin Data%  Meta%  Move Log Cpy%Sync Convert
  fa87dbd5-b437-40b8-8fd1-827a464df10a vg4 Vwi-aotz--  1.27t thin-pool-4        92.93                                  
  thin-pool-4                          vg4 twi-aotz-- <1.31t                    90.37  56.11   

Both thin pool and vg alerts are triggered.
Screenshot from 2022-06-13 13-10-45

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sp98
Copy link
Contributor Author

sp98 commented Jun 9, 2022

Tests are not looking good. Volume Group alerts are not firing. Looking into that.

sp98 added 2 commits June 13, 2022 13:18
VolumeGroupUsageAtThresholdNearFull will be sent when used VG size and
thin pool size exceeds 75%.

VolumeGroupUsageAtThresholdCritical will be sent when VG size and thin
pool size exeeds 85%.

Signed-off-by: Santosh Pillai <sapillai@redhat.com>
Signed-off-by: Santosh Pillai <sapillai@redhat.com>
@sp98 sp98 marked this pull request as ready for review June 13, 2022 07:49
@sp98 sp98 changed the title [WIP]: send vg alerts only when thin pool alerts are also triggered send vg alerts only when thin pool alerts are also triggered Jun 13, 2022
@sp98 sp98 requested a review from nbalacha June 13, 2022 07:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2022
@sp98 sp98 requested a review from iamniting June 13, 2022 07:50
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, nbalacha, sp98

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@openshift-ci openshift-ci bot merged commit 08869c3 into openshift:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants