-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send vg alerts only when thin pool alerts are also triggered #205
Conversation
Skipping CI for Draft Pull Request. |
Tests are not looking good. Volume Group alerts are not firing. Looking into that. |
VolumeGroupUsageAtThresholdNearFull will be sent when used VG size and thin pool size exceeds 75%. VolumeGroupUsageAtThresholdCritical will be sent when VG size and thin pool size exeeds 85%. Signed-off-by: Santosh Pillai <sapillai@redhat.com>
Signed-off-by: Santosh Pillai <sapillai@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, nbalacha, sp98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Trigger VolumeGroupUsage alerts only if actual size is occupied via the thin pool.
VolumeGroupUsageAtThresholdNearFull
will be sent when used VG size andthin pool size exceeds 75%.
VolumeGroupUsageAtThresholdCritical
will be sent when VG size and thinpool size exceeds 85%.
Testing
Current behavior: size-percent is 90
Behavior after this PR:
Both thin pool and vg alerts are triggered.