Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move function to different file #250

Merged
merged 1 commit into from
Sep 1, 2022
Merged

refactor: move function to different file #250

merged 1 commit into from
Sep 1, 2022

Conversation

nbalacha
Copy link
Contributor

Moved the filterAvailableDevices function to the
vgmanager_controller.go function. The filter.go will
have only the filter map and functions.

Signed-off-by: N Balachandran nibalach@redhat.com

Moved the filterAvailableDevices function to the
vgmanager_controller.go function. The filter.go will
have only the filter map and functions.

Signed-off-by: N Balachandran <nibalach@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, nbalacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3c15311 into openshift:main Sep 1, 2022
@nbalacha nbalacha deleted the filter branch September 6, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants