tests: added unit tests for some vgmanager files #252
Conversation
openshift-ci
bot
added
the
approved
pkg/vgmanager/device_age_test.go
Outdated
| } | ||
| func Test_isOlderThan(t *testing.T) { |
There was a problem hiding this comment.
| } | |
| func Test_isOlderThan(t *testing.T) { | |
| } | |
| func Test_isOlderThan(t *testing.T) { |
pkg/vgmanager/filter_test.go
Outdated
| {label: "tc invalid string", device: internal.BlockDevice{ReadOnly: "test"}, expected: true, expectErr: true}, | ||
| } | ||
| for _, tc := range testcases { | ||
|
|
| if tc.expectErr { | ||
| assert.Error(t, err) | ||
| } else { | ||
| assert.NoError(t, err) | ||
| } |
There was a problem hiding this comment.
This func is always returning nil. Do we need this err check at all?
There was a problem hiding this comment.
I wanted to keep it just in case it changes in the future.
| if tc.expectErr { | ||
| assert.Error(t, err) | ||
| } else { | ||
| assert.NoError(t, err) | ||
| } |
| if tc.expectErr { | ||
| assert.Error(t, err) | ||
| } else { | ||
| assert.NoError(t, err) | ||
| } |
pkg/vgmanager/filter_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestIsUsableLoop(t *testing.T) { |
There was a problem hiding this comment.
| func TestIsUsableLoop(t *testing.T) { | |
| func TestIsUsableDeviceType(t *testing.T) { |
| if tc.expectErr { | ||
| assert.Error(t, err) | ||
| } else { | ||
| assert.NoError(t, err) | ||
| } |
pkg/vgmanager/filter_test.go
Outdated
| testcases := []struct { | ||
| label string | ||
| device internal.BlockDevice | ||
| expected bool | ||
| expectErr bool |
There was a problem hiding this comment.
This is used in all TC, We can declare this at one place and make use of it again and again
pkg/vgmanager/filter_test.go
Outdated
| } | ||
|
|
||
| func TestNotReadOnly(t *testing.T) { | ||
| matcher := notReadOnly |
There was a problem hiding this comment.
do we really need this matcher keyword? instead, we can directly make use of the constants.
|
/retest |
pkg/vgmanager/device_age_test.go
Outdated
| } | ||
| func Test_isOlderThan(t *testing.T) { |
This commit adds unit tests for filter.go and device_age.go as part of the initiative to improve code coverage Signed-off-by: N Balachandran <nibalach@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, nbalacha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit adds unit tests for filter.go and device_age.go
as part of the initiative to improve code coverage.
Signed-off-by: N Balachandran nibalach@redhat.com