Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add test ns labels for PSA #278

Merged
merged 1 commit into from
Oct 12, 2022
Merged

fix: add test ns labels for PSA #278

merged 1 commit into from
Oct 12, 2022

Conversation

nbalacha
Copy link
Contributor

The PSA changes in OCP 4.12 prevent pods from starting as ns are labeled restricted by default. This commit sets the label pod-security.kubernetes.io/enforce: "baseline"
on the lvm-endtoendtest to allow the test pods to run. This also renames a file to conform to the naming convention.

Signed-off-by: N Balachandran nibalach@redhat.com

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2022
e2e/helper.go Outdated
@@ -34,6 +34,9 @@ func createNamespace(ctx context.Context, namespace string) error {
label := make(map[string]string)
// label required for monitoring this namespace
label["openshift.io/cluster-monitoring"] = "true"
label["pod-security.kubernetes.io/enforce"] = "baseline"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not we use privileged

@@ -52,6 +55,9 @@ func deleteNamespaceAndWait(ctx context.Context, namespace string) error {
label := make(map[string]string)
// label required for monitoring this namespace
label["openshift.io/cluster-monitoring"] = "true"
label["pod-security.kubernetes.io/enforce"] = "baseline"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleting the namespace should not require labels, Just a name should be enough.

The PSA changes in OCP 4.12 prevent pods from starting as ns are
labeled restricted by default. This commit sets the label
pod-security.kubernetes.io/enforce: "privileged"
on the namespaces created by the e2e tests so pods can run.
This also renames a file to conform to the naming convention.

Signed-off-by: N Balachandran <nibalach@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, nbalacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e82a5df into openshift:main Oct 12, 2022
@nbalacha nbalacha deleted the e2e-failures branch October 13, 2022 05:45
@nbalacha
Copy link
Contributor Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@nbalacha: new pull request created: #280

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants