Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-234: Reduce CPU and Memory requests and remove limits #303

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

suleymanakbas91
Copy link
Contributor

@suleymanakbas91 suleymanakbas91 commented Feb 7, 2023

This PR reduces CPU and Memory requests or all the pods to the "at rest" values shown in the analysis document. It also removes all the CPU and Memory limits from the containers.

Signed-off-by: Suleyman Akbas sakbas@redhat.com

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2023

@suleymanakbas91: This pull request references OCPVE-234 which is a valid jira issue.

In response to this:

Signed-off-by: Suleyman Akbas sakbas@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from nbalacha and sp98 February 7, 2023 17:26
@brandisher brandisher requested review from jeff-roche and removed request for sp98 and nbalacha February 7, 2023 19:08
@jeff-roche
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2023

@suleymanakbas91: This pull request references OCPVE-234 which is a valid jira issue.

In response to this:

This PR reduces CPU and Memory requests or all the pods to the "at rest" values shown in the analysis document. It also removes all the CPU and Memory limits from the containers.

Signed-off-by: Suleyman Akbas sakbas@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
@suleymanakbas91
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@suleymanakbas91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lvm-operator-bundle-e2e-aws 77dbf35 link false /test lvm-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91 suleymanakbas91 merged commit dcfde83 into openshift:main Feb 14, 2023
@suleymanakbas91 suleymanakbas91 deleted the reduce_cpu_memory branch February 14, 2023 09:43
suleymanakbas91 added a commit to suleymanakbas91/assisted-service that referenced this pull request Feb 17, 2023
With openshift/lvm-operator#303, the resource requirements for LVMS has been reduced. Based on this reduction, this PR adjusts the LVMS requirement on Assisted Installer solving https://issues.redhat.com/browse/MGMT-13445.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
suleymanakbas91 added a commit to suleymanakbas91/assisted-service that referenced this pull request Feb 28, 2023
With openshift/lvm-operator#303, the resource requirements for LVMS has been reduced. Based on this reduction, this PR adjusts the LVMS requirement on Assisted Installer solving https://issues.redhat.com/browse/MGMT-13445.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
suleymanakbas91 added a commit to suleymanakbas91/assisted-service that referenced this pull request Feb 28, 2023
With openshift/lvm-operator#303, the resource requirements for LVMS has been reduced. Based on this reduction, this PR adjusts the LVMS requirement on Assisted Installer solving https://issues.redhat.com/browse/MGMT-13445.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
suleymanakbas91 added a commit to suleymanakbas91/assisted-service that referenced this pull request Feb 28, 2023
With openshift/lvm-operator#303, the resource requirements for LVMS has been reduced. Based on this reduction, this PR adjusts the LVMS requirement on Assisted Installer solving https://issues.redhat.com/browse/MGMT-13445.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
suleymanakbas91 added a commit to suleymanakbas91/assisted-service that referenced this pull request Feb 28, 2023
With openshift/lvm-operator#303, the resource requirements for LVMS has been reduced. Based on this reduction, this PR adjusts the LVMS requirement on Assisted Installer solving https://issues.redhat.com/browse/MGMT-13445.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
suleymanakbas91 added a commit to suleymanakbas91/assisted-service that referenced this pull request Feb 28, 2023
With openshift/lvm-operator#303, the resource requirements for LVMS has been reduced. Based on this reduction, this PR adjusts the LVMS requirement on Assisted Installer solving https://issues.redhat.com/browse/MGMT-13445.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
suleymanakbas91 added a commit to suleymanakbas91/assisted-service that referenced this pull request Feb 28, 2023
With openshift/lvm-operator#303, the resource requirements for LVMS has been reduced. Based on this reduction, this PR adjusts the LVMS requirement on Assisted Installer solving https://issues.redhat.com/browse/MGMT-13445.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
suleymanakbas91 added a commit to suleymanakbas91/assisted-service that referenced this pull request Feb 28, 2023
With openshift/lvm-operator#303, the resource requirements for LVMS has been reduced. Based on this reduction, this PR adjusts the LVMS requirement on Assisted Installer solving https://issues.redhat.com/browse/MGMT-13445.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
openshift-merge-robot pushed a commit to openshift/assisted-service that referenced this pull request Mar 1, 2023
…4986)

With openshift/lvm-operator#303, the resource requirements for LVMS has been reduced. Based on this reduction, this PR adjusts the LVMS requirement on Assisted Installer solving https://issues.redhat.com/browse/MGMT-13445.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
…penshift#4986)

With openshift/lvm-operator#303, the resource requirements for LVMS has been reduced. Based on this reduction, this PR adjusts the LVMS requirement on Assisted Installer solving https://issues.redhat.com/browse/MGMT-13445.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants