Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-316: Reduce number of Dockerfiles and simplify Makefile #328

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

suleymanakbas91
Copy link
Contributor

@suleymanakbas91 suleymanakbas91 commented Apr 25, 2023

This PR removes the vgmanager and manager Dockerfiles that are not used anywhere. This also simplifies the Makefile by re-organizing the groups and removing unused variables.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@suleymanakbas91
Copy link
Contributor Author

/test all

@suleymanakbas91 suleymanakbas91 force-pushed the reduce-dockerfiles branch 2 times, most recently from 0d0d581 to 1ea7211 Compare April 25, 2023 09:55
Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
@suleymanakbas91 suleymanakbas91 marked this pull request as ready for review April 25, 2023 10:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2023
@openshift-ci openshift-ci bot requested review from nbalacha and sp98 April 25, 2023 10:04
@suleymanakbas91 suleymanakbas91 changed the title chore: reduce number of Dockerfiles OCPVE-316: Reduce number of Dockerfiles and simplify Makefile Apr 25, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2023

@suleymanakbas91: This pull request references OCPVE-316 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2023

@suleymanakbas91: This pull request references OCPVE-316 which is a valid jira issue.

In response to this:

This PR removes the vgmanager and manager Dockerfiles that are not used anywhere. This also simplifies the Makefile by re-organizing the groups and removing unused variables.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-roche
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@suleymanakbas91
Copy link
Contributor Author

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91 suleymanakbas91 merged commit 7cacafc into openshift:main Apr 25, 2023
@suleymanakbas91 suleymanakbas91 deleted the reduce-dockerfiles branch April 25, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants