Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-300: OCPVE-301: feat: ext4 support #344

Merged
merged 1 commit into from
May 25, 2023

Conversation

jeff-roche
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 24, 2023

@jeff-roche: This pull request references OCPVE-300 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 24, 2023
@openshift-ci openshift-ci bot requested review from qJkee and suleymanakbas91 May 24, 2023 19:15
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@jeff-roche jeff-roche force-pushed the lvm-ext4 branch 2 times, most recently from 9a5242e to 1eb4ee9 Compare May 24, 2023 19:21
@codecov-commenter
Copy link

Codecov Report

Merging #344 (e8474c3) into main (e6814c5) will not change coverage.
The diff coverage is 0.00%.

❗ Current head e8474c3 differs from pull request most recent head 1eb4ee9. Consider uploading reports for the commit 1eb4ee9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   11.65%   11.65%           
=======================================
  Files          21       21           
  Lines        1828     1828           
=======================================
  Hits          213      213           
  Misses       1595     1595           
  Partials       20       20           
Impacted Files Coverage Δ
api/v1alpha1/lvmcluster_types.go 100.00% <ø> (ø)
controllers/topolvm_storageclass.go 0.00% <0.00%> (ø)

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

@jeff-roche: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lvm-operator-bundle-e2e-aws 5093d41 link false /test lvm-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@qJkee
Copy link
Contributor

qJkee commented May 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6ab8b0a into openshift:main May 25, 2023
@@ -0,0 +1,13 @@
- build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-roche could you please remove this file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants