Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-308: Convert todos to jiras #353

Merged
merged 5 commits into from
May 30, 2023
Merged

OCPVE-308: Convert todos to jiras #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e4086e
cleanup: remove golanglintci todo
brandisher May 26, 2023
967edb8
cleanup: remove lvm config todo
brandisher May 26, 2023
00eb884
cleanup: remove lvmcluseter_controller todo
brandisher May 26, 2023
a249d19
cleanup: remove topolvm_controller todo
brandisher May 26, 2023
7f96143
cleanup: remove lvm todo
brandisher May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/golangci-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ jobs:
# working-directory: somedir

# Optional: golangci-lint command line arguments.
# TODO: remove --skip-files once logic is implemented
# NO_FUTURE args from https://github.com/golangci/golangci-lint-action/issues/119
args: >
--out-${NO_FUTURE}format colored-line-number -E gosec --timeout=6m --skip-files
Expand Down
5 changes: 0 additions & 5 deletions api/v1alpha1/lvmcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,6 @@ type DeviceClass struct {
// +optional
NodeSelector *corev1.NodeSelector `json:"nodeSelector,omitempty"`

// TODO: add support for various LVM settings
// // Config for this deviceClass, lvm settings are a field here
// // +optional
// Config *DeviceClassConfig `json:"config,omitempty"`

// ThinPoolConfig contains configurations for the thin-pool
// +kubebuilder:validation:Required
// +required
Expand Down
5 changes: 0 additions & 5 deletions api/v1alpha1/lvmvolumegroup_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,6 @@ type LVMVolumeGroupSpec struct {
// +optional
NodeSelector *corev1.NodeSelector `json:"nodeSelector,omitempty"`

// TODO: add support for various LVM settings
// // Config for this deviceClass, lvm settings are a field here
// // +optional
// Config *DeviceClassConfig `json:"config,omitempty"`

// ThinPoolConfig contains configurations for the thin-pool
// +kubebuilder:validation:Required
// +required
Expand Down
4 changes: 0 additions & 4 deletions controllers/lvmcluster_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ type LVMClusterReconciler struct {

// Reconcile is part of the main kubernetes reconciliation loop which aims to
// move the current state of the cluster closer to the desired state.
// TODO(user): Modify the Reconcile function to compare the state specified by
// the LVMCluster object against the actual cluster state, and then
// perform operations to make the cluster state reflect the state specified by
// the user.
//
// For more details, check Reconcile and its Result here:
// - https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.10.0/pkg/reconcile
Expand Down
1 change: 0 additions & 1 deletion controllers/topolvm_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ func getControllerDeployment(lvmCluster *lvmv1alpha1.LVMCluster, namespace strin
{Name: "certs", VolumeSource: corev1.VolumeSource{EmptyDir: &corev1.EmptyDirVolumeSource{}}},
}

// TODO: Remove custom generation of TLS certs, current it's being used in topolvm controller manager
initContainers := []corev1.Container{
initContainer(initImage),
}
Expand Down
1 change: 0 additions & 1 deletion pkg/vgmanager/lvm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ func (vg VolumeGroup) Delete(exec internal.Executor) error {
func GetVolumeGroup(exec internal.Executor, name string) (*VolumeGroup, error) {
res := new(vgsOutput)

// TODO: Check if `vgs <vg_name> --reportformat json` can be used to filter out the exact volume group name.
args := []string{
"vgs", "--units", "g", "--reportformat", "json",
}
Expand Down