[release-4.14] OCPBUGS-17857: Do not error during capacity check if annotation does not exist on the node

[suleymanakbas91]

fix: do not error during capacity check if annotation does not exist on the node
fix: ensure panic safety in PVC controller for non-set storageClassName

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-17857, which is invalid:

• expected Jira Issue OCPBUGS-17857 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

fix: ensure panic safety in PVC controller for non-set storageClassName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-17857, which is invalid:

• expected Jira Issue OCPBUGS-17857 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

fix: do not error during capacity check if annotation does not exist on the node
fix: ensure panic safety in PVC controller for non-set storageClassName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[suleymanakbas91]

/jira refresh

[openshift-ci-robot]

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-17857, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-17805 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-17805 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
• bug has dependents

Requesting review from QA contact:
/cc @radeore

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/test lvm-operator-e2e-aws

[jakobmoellerdev]

/lgtm

[codecov-commenter]

Codecov Report

Merging #389 (31ab0f8) into release-4.14 (e0ccb5c) will increase coverage by 0.78%.
Report is 4 commits behind head on release-4.14.
The diff coverage is 78.94%.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.14     #389      +/-   ##
================================================
+ Coverage         15.76%   16.55%   +0.78%     
================================================
  Files                23       24       +1     
  Lines              1992     2157     +165     
================================================
+ Hits                314      357      +43     
- Misses             1654     1772     +118     
- Partials             24       28       +4     

Files Changed	Coverage Δ
controllers/persistent-volume-claim/controller.go	60.29% <78.94%> (ø)

... and 2 files with indirect coverage changes

[openshift-ci]

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@suleymanakbas91: Jira Issue OCPBUGS-17857: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#389

Jira Issue OCPBUGS-17857 has been moved to the MODIFIED state.

In response to this:

fix: do not error during capacity check if annotation does not exist on the node
fix: ensure panic safety in PVC controller for non-set storageClassName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.