Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPVE-339: test: validate snapshot content #401

Merged
merged 3 commits into from
Aug 30, 2023
Merged

OCPVE-339: test: validate snapshot content #401

merged 3 commits into from
Aug 30, 2023

Conversation

jakobmoellerdev
Copy link
Contributor

Adds test logic to validate content that is written to the volume managed by TopoLVM and cloned / snapshotted

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2023 •
edited by openshift-ci bot
Loading

@jakobmoellerdev: This pull request references OCPVE-399 which is a valid jira issue.

In response to this:

Adds test logic to validate content that is written to the volume managed by TopoLVM and cloned / snapshotted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2023
@jakobmoellerdev jakobmoellerdev changed the title OCPVE-399: test: validate snapshot content OCPVE-339: test: validate snapshot content Aug 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2023 •
edited by openshift-ci bot
Loading

@jakobmoellerdev: This pull request references OCPVE-339 which is a valid jira issue.

In response to this:

Adds test logic to validate content that is written to the volume managed by TopoLVM and cloned / snapshotted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 28, 2023
@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-339-Validate-Snapshot-Content branch 2 times, most recently from f776550 to 1c15bcd Compare August 28, 2023 16:50
@jakobmoellerdev
Copy link
Contributor Author

/test all

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

@jakobmoellerdev
Copy link
Contributor Author

/retest-required

2 similar comments
@jakobmoellerdev
Copy link
Contributor Author

/retest-required

@jakobmoellerdev
Copy link
Contributor Author

/retest-required

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-339-Validate-Snapshot-Content branch from 1c15bcd to 735018f Compare August 29, 2023 09:45
@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review August 29, 2023 09:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023 •
edited
Loading

Codecov Report

Merging #401 (d1c043d) into main (1570d03) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   56.90%   56.90%           
=======================================
  Files          27       27           
  Lines        2193     2193           
=======================================
  Hits         1248     1248           
  Misses        851      851           
  Partials       94       94

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-339-Validate-Snapshot-Content branch 2 times, most recently from db06715 to b0c47b1 Compare August 29, 2023 14:40
@jakobmoellerdev
Copy link
Contributor Author

/retest-required

@jakobmoellerdev
test: add pod data fetching on snapshots
3ac9863 
Add spdystream for managing multiplexed streams over SPDY

Updated dependencies in go.mod, go.sum and vendor/modules.txt to include spdystream library. This is used for managing multiple streams over SPDY, a protocol for multiplexed and prioritized data communication over a single connection.

Additionally, a content testing file `content_tester.go` is added to the e2e test suite, which utilizes the newly included spdystream to write and get data in a pod.

This commit also includes adding the corresponding SPDY library files under the `vendor` directory.
@jakobmoellerdev
test: refactor disk cleanup to be more resilient
b1e318e
@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-339-Validate-Snapshot-Content branch from 33bfef7 to c4cac48 Compare August 30, 2023 08:28
@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-339-Validate-Snapshot-Content branch from c4cac48 to d1c043d Compare August 30, 2023 08:30
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3596bc6 into openshift:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-roche jeff-roche Awaiting requested review from jeff-roche

@suleymanakbas91 suleymanakbas91 Awaiting requested review from suleymanakbas91

Assignees

@suleymanakbas91 suleymanakbas91

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakobmoellerdev @openshift-ci-robot @codecov-commenter @suleymanakbas91 @openshift-merge-robot