OCPVE-677: chore: change finalizer logic in vgmanager to per-node finalizer

[jakobmoellerdev]

Part of findings during vgmanager testing. Changes the finalizer logic of vgmanager to the following:

• "lvm.openshift.io/lvmvolumegroup" gets deprecated and if found on existing volumegroups, it will be removed
• "cleanup.vgmanager.node.topolvm.io/$NODE_NAME" gets introduced for every node interacting with the volume group and only removed once processDelete is successful. If all nodes successfully delete vg, the VolumeGroup should not have any other finalizers and may be dropped.

[openshift-ci-robot]

@jakobmoellerdev: This pull request references OCPVE-677 which is a valid jira issue.

In response to this:

Part of findings during vgmanager testing. Changes the finalizer logic of vgmanager to the following:

• "lvm.openshift.io/lvmvolumegroup" gets deprecated and if found on existing volumegroups, it will be removed
• "cleanup.vgmanager.node.topolvm.io/$NODE_NAME" gets introduced for every node interacting with the volume group and only removed once processDelete is successful. If all nodes successfully delete vg, the VolumeGroup should not have any other finalizers and may be dropped.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/retest-required

[suleymanakbas91]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8da92ee and 2 for PR HEAD 25b32cc in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ceed42e and 1 for PR HEAD 25b32cc in total

[codecov-commenter]

Codecov Report

Merging #408 (4b7a879) into main (8da92ee) will decrease coverage by 0.42%.
Report is 4 commits behind head on main.
The diff coverage is 30.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   55.01%   54.59%   -0.42%     
==========================================
  Files          27       27              
  Lines        2341     2337       -4     
==========================================
- Hits         1288     1276      -12     
- Misses        965      974       +9     
+ Partials       88       87       -1     

Files Changed	Coverage Δ
pkg/vgmanager/vgmanager_controller.go	9.24% <0.00%> (-0.25%)	⬇️
controllers/lvm_volumegroup.go	79.66% <54.54%> (-2.03%)	⬇️

... and 1 file with indirect coverage changes

[jakobmoellerdev]

/test lvm-operator-e2e-aws

[jakobmoellerdev]

/test lvm-operator-e2e-aws-sno

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8fce2eb and 0 for PR HEAD 25b32cc in total

[suleymanakbas91]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 3386fe2 and 2 for PR HEAD 4b7a879 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8208b3a and 1 for PR HEAD 4b7a879 in total

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[suleymanakbas91]

/lgtm