Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-265: chore: add pre-commit config #419

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

Adds all missing github actions inside pre-commit and also writes a small doc part about pre-commits. This way we can already call a lot of these checks automated within our dev setup and afterwards also setup pre-commit to run on the pipelines.

Includes:

  • golangcilint
  • yamllint
  • regular precommit checks for other file types
  • commitlint
  • codespell
  • bashate
  • make verify

Once this is merged, it can also be used as a custom pipeline step

Also fixes all current issues in the project for these linters so that we run of a green base.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 12, 2023

@jakobmoellerdev: This pull request references OCPVE-265 which is a valid jira issue.

In response to this:

Adds all missing github actions inside pre-commit and also writes a small doc part about pre-commits. This way we can already call a lot of these checks automated within our dev setup and afterwards also setup pre-commit to run on the pipelines.

Includes:

  • golangcilint
  • yamllint
  • regular precommit checks for other file types
  • commitlint
  • codespell
  • bashate
  • make verify

Once this is merged, it can also be used as a custom pipeline step

Also fixes all current issues in the project for these linters so that we run of a green base.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2023
@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 12, 2023
@openshift-ci openshift-ci bot requested review from brandisher and qJkee September 12, 2023 10:41
@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-265-precommit branch 2 times, most recently from dd6302b to b67381a Compare September 12, 2023 10:50
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #419 (2cc4369) into main (99c6473) will increase coverage by 0.23%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
+ Coverage   62.17%   62.41%   +0.23%     
==========================================
  Files          27       27              
  Lines        2345     2336       -9     
==========================================
  Hits         1458     1458              
+ Misses        755      747       -8     
+ Partials      132      131       -1     
Files Changed Coverage Δ
pkg/vgmanager/lv_attr.go 92.59% <ø> (ø)
pkg/vgmanager/status.go 60.22% <ø> (+4.43%) ⬆️
pkg/vgmanager/vgmanager_controller.go 45.14% <ø> (+0.28%) ⬆️

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit 26bda34 into openshift:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants