-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPVE-265: chore: add pre-commit config #419
OCPVE-265: chore: add pre-commit config #419
Conversation
@jakobmoellerdev: This pull request references OCPVE-265 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dd6302b
to
b67381a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 62.17% 62.41% +0.23%
==========================================
Files 27 27
Lines 2345 2336 -9
==========================================
Hits 1458 1458
+ Misses 755 747 -8
+ Partials 132 131 -1
|
/test lvm-operator-e2e-aws-sno |
b67381a
to
2cc4369
Compare
/test lvm-operator-e2e-aws |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev, suleymanakbas91 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds all missing github actions inside pre-commit and also writes a small doc part about pre-commits. This way we can already call a lot of these checks automated within our dev setup and afterwards also setup pre-commit to run on the pipelines.
Includes:
Once this is merged, it can also be used as a custom pipeline step
Also fixes all current issues in the project for these linters so that we run of a green base.