OCPBUGS-18708: fix: disallow creation of LVMCluster outside of operator namespace and restrict cache

[jakobmoellerdev]

Introduces 2 new Limitations and tests for them in the Creation of LVMClusters:

1. LVMCluster Duplicates in one namespace are not allowed
2. LVMCluster can only be created in the Namespace of the Operator introspected by POD_NAMESPACE

This leads to us only being allowed exactly one LVMCluster in the Namespace of the operator

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-18708, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/test all

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[jakobmoellerdev]

/jira refresh

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-18708, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/test all

[jakobmoellerdev]

/retest-required

[jakobmoellerdev]

/retest-required

[jakobmoellerdev]

/retest-required

[jakobmoellerdev]

/test lvm-operator-e2e-aws-sno

[jakobmoellerdev]

/test all

[jakobmoellerdev]

/test all

[codecov-commenter]

Codecov Report

Merging #428 (f755bd0) into main (f2d644a) will increase coverage by 1.33%.
The diff coverage is 47.05%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   62.34%   63.68%   +1.33%     
==========================================
  Files          27       28       +1     
  Lines        2332     2360      +28     
==========================================
+ Hits         1454     1503      +49     
+ Misses        746      709      -37     
- Partials      132      148      +16     

Files Changed	Coverage Δ
pkg/cluster/namespace.go	0.00% <0.00%> (ø)
api/v1alpha1/lvmcluster_webhook.go	24.87% <52.17%> (+24.87%)	⬆️

[jakobmoellerdev]

/retest-required

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[suleymanakbas91]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jakobmoellerdev: Jira Issue OCPBUGS-18708: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#428

Jira Issue OCPBUGS-18708 has been moved to the MODIFIED state.

In response to this:

Introduces 2 new Limitations and tests for them in the Creation of LVMClusters:

1. LVMCluster Duplicates in one namespace are not allowed
2. LVMCluster can only be created in the Namespace of the Operator introspected by POD_NAMESPACE

This leads to us only being allowed exactly one LVMCluster in the Namespace of the operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.