Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor fixes across components #43

Closed
wants to merge 3 commits into from
Closed

fix: minor fixes across components #43

wants to merge 3 commits into from

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Dec 23, 2021 •
edited
Loading

  • consistent return statements and logging in all CSI Component reconcile units
  • use default values for socket paths from topolvm project
  • deviceClass name validation at CRD level to be able to use that in storage class name

@leelavg
fix: use consistent return statements across components
92dd029 
Signed-off-by: Leela Venkaiah G <lgangava@redhat.com>
@leelavg
fix: define default socket paths for CSI and LVMd
d9bd067 
Signed-off-by: Leela Venkaiah G <lgangava@redhat.com>
@leelavg
fix: validate deviceClass name to be usable in storageClass
61aa9d2 
Fixes: #40

Signed-off-by: Leela Venkaiah G <lgangava@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmolmo, leelavg

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg leelavg marked this pull request as ready for review December 24, 2021 02:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2021
@leelavg leelavg marked this pull request as draft December 24, 2021 07:08
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2021
@leelavg
Copy link
Contributor Author

leelavg commented Dec 24, 2021

@leelavg leelavg closed this Dec 24, 2021
@leelavg leelavg deleted the minor-fixes branch December 29, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmolmo jmolmo jmolmo approved these changes

Assignees

@jmolmo jmolmo

Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leelavg @jmolmo