OCPVE-706: Secure metrics endpoints

[suleymanakbas91]

This PR secures the metrics endpoints exposed in lvm-operator, vg-manager, and topolvm-node. For lvm-operator and vg-manager, this uses the new secure metrics serving feature introduced in kubernetes-sigs/controller-runtime#2407. For topolvm-node, this PR introduces a sidecar container kube-rbac-proxy which handles the TLS connection.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@suleymanakbas91: This pull request references OCPVE-706 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@suleymanakbas91: This pull request references OCPVE-706 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This PR secures the metrics endpoints exposed in lvm-operator, vg-manager, and topolvm-node. For lvm-operator and vg-manager, this uses the new secure metrics serving feature introduced in kubernetes-sigs/controller-runtime#2407. For topolvm-node, this PR introduces a sidecar container kube-rbac-proxy which handles the TLS connection.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov-commenter]

Codecov Report

Merging #431 (45542ba) into main (2c853f5) will increase coverage by 0.57%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   60.64%   61.21%   +0.57%     
==========================================
  Files          28       28              
  Lines        2376     2411      +35     
==========================================
+ Hits         1441     1476      +35     
  Misses        788      788              
  Partials      147      147              

Files Changed	Coverage Δ
controllers/defaults.go	50.00% <ø> (ø)
controllers/topolvm_node.go	95.74% <100.00%> (+0.60%)	⬆️
controllers/vgmanager_daemonset.go	100.00% <100.00%> (ø)

[jakobmoellerdev]

Just one minor nit and some questions, overall looks great, this is a huge improvement! 🎉

[jakobmoellerdev]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 2c853f5 and 2 for PR HEAD 45542ba in total

[suleymanakbas91]

/retest-required

[suleymanakbas91]

/retest

[suleymanakbas91]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 12ae9ae and 1 for PR HEAD 45542ba in total

[openshift-ci]

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.