Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-390: use specific cipher suites for kube-rbac-proxy #433

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

suleymanakbas91
Copy link
Contributor

@suleymanakbas91 suleymanakbas91 commented Sep 27, 2023

This PR passes specific cipher suites for kube-rbac-proxy to make it run more securely.

This also removes topolvm-metrics Role and RoleBinding as it is already covered with lvms-metrics Role and RoleBinding.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 27, 2023

@suleymanakbas91: This pull request references OCPVE-390 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

This PR passes specific ciphers for kube-rbac-proxy to make it run more securely.

This also removes topolvm-metrics Role and RoleBinding as it is already covered with lvms-metrics Role and RoleBinding.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 27, 2023
@suleymanakbas91 suleymanakbas91 changed the title OCPVE-390: use specific ciphers for kube-rbac-proxy OCPVE-390: use specific cipher suites for kube-rbac-proxy Sep 27, 2023
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 27, 2023
@openshift-ci openshift-ci bot requested review from jeff-roche and qJkee September 27, 2023 09:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 27, 2023

@suleymanakbas91: This pull request references OCPVE-390 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

This PR passes specific cipher suites for kube-rbac-proxy to make it run more securely.

This also removes topolvm-metrics Role and RoleBinding as it is already covered with lvms-metrics Role and RoleBinding.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Suleyman Akbas <sakbas@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

Merging #433 (0a20e29) into main (b1f83fe) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   65.82%   65.80%   -0.02%     
==========================================
  Files          28       28              
  Lines        2405     2404       -1     
==========================================
- Hits         1583     1582       -1     
  Misses        677      677              
  Partials      145      145              
Files Coverage Δ
controllers/topolvm_node.go 95.72% <100.00%> (-0.02%) ⬇️

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2023

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bd11b2a into openshift:main Sep 27, 2023
@suleymanakbas91 suleymanakbas91 deleted the rbac-proxy branch September 27, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants