Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-346: chore: move all controllers under internal/controllers #434

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Sep 29, 2023

Moves all controllers (including vgmanager) under internal/controllers after templating recommendations based on https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2023

@jakobmoellerdev: This pull request references OCPVE-346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2023

@jakobmoellerdev: This pull request references OCPVE-346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2023

@jakobmoellerdev: This pull request references OCPVE-346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Moves all controllers (including vgmanager) under pkg/controllers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2023

@jakobmoellerdev: This pull request references OCPVE-346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Moves all controllers (including vgmanager) under internal/controllers after templating recommendations based on https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev jakobmoellerdev changed the title OCPVE-346: chore: move all controllers under pkg/controllers OCPVE-346: chore: move all controllers under internal/controllers Sep 29, 2023
@jakobmoellerdev
Copy link
Contributor Author

/test all

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

Merging #434 (68f15f0) into main (adbdaf2) will decrease coverage by 8.80%.
The diff coverage is 71.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   66.06%   57.27%   -8.80%     
==========================================
  Files          31       20      -11     
  Lines        2505     1533     -972     
==========================================
- Hits         1655      878     -777     
+ Misses        696      539     -157     
+ Partials      154      116      -38     
Files Coverage Δ
api/v1alpha1/lvmcluster_webhook.go 82.41% <ø> (ø)
internal/cluster/leaderelection.go 66.66% <ø> (ø)
internal/cluster/namespace.go 0.00% <ø> (ø)
internal/cluster/sno.go 72.72% <ø> (ø)
internal/cluster/type.go 0.00% <ø> (ø)
.../controllers/persistent-volume-claim/controller.go 60.29% <100.00%> (ø)
internal/controllers/vgmanager/devices.go 80.17% <ø> (ø)
internal/controllers/vgmanager/dmsetup/dmsetup.go 82.35% <ø> (ø)
internal/controllers/vgmanager/filter/filter.go 73.52% <ø> (ø)
internal/controllers/vgmanager/lv_attr.go 92.59% <ø> (ø)
... and 7 more

... and 11 files with indirect coverage changes

@jakobmoellerdev
Copy link
Contributor Author

/test lvm-operator-e2e-aws-sno

@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review September 29, 2023 15:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2023

@jakobmoellerdev: This pull request references OCPVE-346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Moves all controllers (including vgmanager) under internal/controllers after templating recommendations based on https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-346-consolidate-controllers branch from 7d3d8b4 to be71047 Compare October 2, 2023 15:16
@openshift-ci openshift-ci bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2023

@jakobmoellerdev: This pull request references OCPVE-346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Moves all controllers (including vgmanager) under internal/controllers after templating recommendations based on https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2023

@jakobmoellerdev: This pull request references OCPVE-346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Moves all controllers (including vgmanager) under internal/controllers after templating recommendations based on https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

docs/troubleshooting.md Outdated Show resolved Hide resolved
internal/cluster/namespace.go Outdated Show resolved Hide resolved
internal/controllers/constants/constants.go Outdated Show resolved Hide resolved
internal/controllers/lvmcluster/lvmcluster_controller.go Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2023

@jakobmoellerdev: This pull request references OCPVE-346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Moves all controllers (including vgmanager) under internal/controllers after templating recommendations based on https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-346-consolidate-controllers branch from be71047 to 069a5b9 Compare October 4, 2023 08:21
Signed-off-by: Jakob Möller <jmoller@redhat.com>
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 4, 2023

@jakobmoellerdev: This pull request references OCPVE-346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Moves all controllers (including vgmanager) under internal/controllers after templating recommendations based on https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-346-consolidate-controllers branch from 069a5b9 to 68f15f0 Compare October 4, 2023 08:22
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 4, 2023

@jakobmoellerdev: This pull request references OCPVE-346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Moves all controllers (including vgmanager) under internal/controllers after templating recommendations based on https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleymanakbas91
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 4, 2023

@jakobmoellerdev: This pull request references OCPVE-346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Moves all controllers (including vgmanager) under internal/controllers after templating recommendations based on https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 4, 2023

@jakobmoellerdev: This pull request references OCPVE-346 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but it targets "openshift-4.15" instead.

In response to this:

Moves all controllers (including vgmanager) under internal/controllers after templating recommendations based on https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 88db49d into openshift:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants