Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPVE-738: feat: migrate to FBC for catalog in makefile #458

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Oct 20, 2023

Migrates the index based bundling to the File Based Catalog format https://olm.operatorframework.io/docs/reference/file-based-catalogs/#opm-init

Creates a catalog directory in the repo that contains the FBC data. Also introduces a new verify-catalog script together with adjustments to the makefile to ensure that a catalog can always be built from the bundle image.

Existing commands catalog-build and catalog-push are not touched, they simply now use a newer version of OPM and different commands under the hood. behavior is exactly the same as before in terms of use, and the deploy-with-olm command works the same as before

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2023

@jakobmoellerdev: This pull request references OCPVE-738 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Migrates the index based bundling to the File Based Catalog format https://olm.operatorframework.io/docs/reference/file-based-catalogs/#opm-init

Creates a catalog directory in the repo that contains the FBC data. Also introduces a new verify-catalog script together with adjustments to the makefile to ensure that a catalog can always be built from the bundle image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2023

@jakobmoellerdev: This pull request references OCPVE-738 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Migrates the index based bundling to the File Based Catalog format https://olm.operatorframework.io/docs/reference/file-based-catalogs/#opm-init

Creates a catalog directory in the repo that contains the FBC data. Also introduces a new verify-catalog script together with adjustments to the makefile to ensure that a catalog can always be built from the bundle image.

Existing commands catalog-build and catalog-push are not touched, they simply now use a newer version of OPM and different commands under the hood. behavior is exactly the same as before in terms of use, and the deploy-with-olm command works the same as before

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-738-filebased-opm branch from 5d15548 to 3c81846 Compare October 20, 2023 15:23
Signed-off-by: Jakob Möller <jmoller@redhat.com>
@jakobmoellerdev jakobmoellerdev force-pushed the OCPVE-738-filebased-opm branch from 3c81846 to 757a6fe Compare October 20, 2023 15:35
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@openshift-ci openshift-ci bot merged commit cbe8778 into openshift:main Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants