OCPBUGS-13558: fix: refactor node removal controller

[jakobmoellerdev]

This refactors the node removal controller to not require a finalizer anymore on the node.

It does this by watching LVMVolumeGroupNodeStatus instead of Node as its base reconciled object. This allows us to drop the Field Indexer for Nodes and also 2 permissions on the Node reconciler. Additionally it should make the deletion much more stable and we now run the reconciler not only on SNO, but on all topologies because even SNO can technically add worker nodes.

Cases:

1. Node and NodeStatus are present - nothing happens
2. Node is present but NodeStatus isn't - removal reconciler ignores the node because its not finding a status to check
3. NodeStatus is present but Node isn't - removal controller fetches the node status on startup and on cache refresh, sees that the node is gone, and triggers a delete for the node status
4. NodeStatus is present and Node is about to get deleted - removal controller gets an event for the Node deletion and immediately reacts by removing the node status

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-13588, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target the "4.15.0" version, but no target version was set
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Not a Bug) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This refactors the node removal controller to not require a finalizer anymore on the node.

It does this by watching LVMVolumeGroupNodeStatus instead of Node as its base reconciled object.

Cases:

1. Node and NodeStatus are present - nothing happens
2. Node is present but NodeStatus isn't - removal reconciler ignores the node because its not finding a status to check
3. NodeStatus is present but Node isn't - removal controller fetches the node status on startup and on cache refresh, sees that the node is gone, and triggers a delete for the node status
4. NodeStatus is present and Node is about to get deleted - removal controller gets an event for the Node deletion and immediately reacts by removing the node status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jakobmoellerdev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-13558, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This refactors the node removal controller to not require a finalizer anymore on the node.

It does this by watching LVMVolumeGroupNodeStatus instead of Node as its base reconciled object. This allows us to drop the Field Indexer for Nodes and also 2 permissions on the Node reconciler. Additionally it should make the deletion much more stable and we now run the reconciler not only on SNO, but on all topologies because even SNO can technically add worker nodes.

Cases:

1. Node and NodeStatus are present - nothing happens
2. Node is present but NodeStatus isn't - removal reconciler ignores the node because its not finding a status to check
3. NodeStatus is present but Node isn't - removal controller fetches the node status on startup and on cache refresh, sees that the node is gone, and triggers a delete for the node status
4. NodeStatus is present and Node is about to get deleted - removal controller gets an event for the Node deletion and immediately reacts by removing the node status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jakobmoellerdev]

/retest

[jakobmoellerdev]

/test lvm-operator-e2e-aws

[jakobmoellerdev]

/test lvm-operator-e2e-aws

[jakobmoellerdev]

/test lvm-operator-e2e-aws

[jakobmoellerdev]

/testlvm-operator-e2e-aws

[jakobmoellerdev]

/test lvm-operator-e2e-aws

[jakobmoellerdev]

/test lvm-operator-e2e-aws

[jakobmoellerdev]

/retest

[jakobmoellerdev]

/test lvm-operator-e2e-aws

[suleymanakbas91]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cf96cf3 and 2 for PR HEAD 18828f8 in total

[jakobmoellerdev]

/test lvm-operator-e2e-aws

[openshift-ci]

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jakobmoellerdev: Jira Issue OCPBUGS-13558: All pull requests linked via external trackers have merged:

• openshift/lvm-operator#372
• openshift/lvm-operator#479

Jira Issue OCPBUGS-13558 has been moved to the MODIFIED state.

In response to this:

This refactors the node removal controller to not require a finalizer anymore on the node.

It does this by watching LVMVolumeGroupNodeStatus instead of Node as its base reconciled object. This allows us to drop the Field Indexer for Nodes and also 2 permissions on the Node reconciler. Additionally it should make the deletion much more stable and we now run the reconciler not only on SNO, but on all topologies because even SNO can technically add worker nodes.

Cases:

1. Node and NodeStatus are present - nothing happens
2. Node is present but NodeStatus isn't - removal reconciler ignores the node because its not finding a status to check
3. NodeStatus is present but Node isn't - removal controller fetches the node status on startup and on cache refresh, sees that the node is gone, and triggers a delete for the node status
4. NodeStatus is present and Node is about to get deleted - removal controller gets an event for the Node deletion and immediately reacts by removing the node status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.