Fix typos, Rename reconcileUnit -> resourceManager, add context.Context to args #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
StorageClass creation often has parameters. We're allowing users to create it for now to avoid managing all the parameters in an immutable storageclass. Signed-off-by: Rohan CJ <rohantmp@gmail.com>
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
rohantmp
changed the title
|
Apologies for the mixed-bag PR. None of this is controversial and it's early development. Prioritized speed vs separate PR. Hope that's OK |
Signed-off-by: Rohan CJ <rohantmp@gmail.com>
rohantmp
force-pushed
the
resourceManager
branch
from
01882ac to
5067332
Compare
nbalacha
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nbalacha