Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPEDGE-746: feat!: Micro LVMS - Edge / Low Resource Optimized LVMS #533

Merged

Conversation

jakobmoellerdev
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 14, 2023
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@jakobmoellerdev jakobmoellerdev force-pushed the micro-lvms-rebased branch 2 times, most recently from ec814a2 to 50d1252 Compare December 14, 2023 15:35
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Merging #533 (d7f215b) into main (717528e) will increase coverage by 0.07%.
The diff coverage is 67.62%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   82.10%   82.17%   +0.07%     
==========================================
  Files          24       24              
  Lines        1788     1812      +24     
==========================================
+ Hits         1468     1489      +21     
+ Misses        219      212       -7     
- Partials      101      111      +10     
Files Coverage Δ
internal/cluster/namespace.go 100.00% <ø> (ø)
internal/controllers/vgmanager/devices.go 81.73% <100.00%> (-0.16%) ⬇️
internal/controllers/vgmanager/lvm/lvm.go 100.00% <100.00%> (ø)
internal/controllers/vgmanager/wipefs/wipefs.go 87.50% <100.00%> (+0.83%) ⬆️
internal/controllers/lvmcluster/controller.go 62.25% <0.00%> (-0.73%) ⬇️
internal/controllers/vgmanager/dmsetup/dmsetup.go 75.00% <62.50%> (-7.36%) ⬇️
internal/controllers/vgmanager/filter/filter.go 85.45% <66.66%> (+11.92%) ⬆️
internal/controllers/vgmanager/status.go 81.81% <56.00%> (+1.11%) ⬆️
internal/controllers/vgmanager/controller.go 74.87% <44.44%> (-1.99%) ⬇️

@jakobmoellerdev
Copy link
Contributor Author

/test snyk-code

@jakobmoellerdev jakobmoellerdev changed the title feat: Micro LVMS feat!: Micro LVMS - Edge / Low Resource Optimized LVMS Dec 14, 2023
@jakobmoellerdev jakobmoellerdev changed the title feat!: Micro LVMS - Edge / Low Resource Optimized LVMS OCPEDGE-746: feat!: Micro LVMS - Edge / Low Resource Optimized LVMS Dec 14, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 14, 2023

@jakobmoellerdev: This pull request references OCPEDGE-746 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Dockerfile Show resolved Hide resolved
internal/controllers/vgmanager/lsblk/lsblk.go Outdated Show resolved Hide resolved
cmd/vgmanager/vgmanager.go Outdated Show resolved Hide resolved
@jakobmoellerdev jakobmoellerdev force-pushed the micro-lvms-rebased branch 2 times, most recently from f22f6ea to bdbeb7d Compare December 15, 2023 11:40
@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@suleymanakbas91
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 717528e and 2 for PR HEAD bdbeb7d in total

Co-authored-by: Suleyman Akbas <sakbas@redhat.com>
Signed-off-by: Jakob Möller <jmoller@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
@suleymanakbas91
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

@jakobmoellerdev: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 63551d4 into openshift:main Dec 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants